Changed CLI View Prefix #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodyt
requested review from
mikemhenry,
syjlee and
a team
and removed request for
a team
bdice
reviewed
Jun 14, 2022
There was a problem hiding this comment.
This looks great! However, this is an API breaking change and should target next instead of master so that it goes into version 2.0. Can you rebase this on next and change the target branch? (I can help if you want -- it is a quick process but I want to let you try it if haven't before.)
… duplicate view in test. Still need to add tests
bdice
force-pushed
the
feature/cli-view-prefix
branch
from
e92cb75
to
a58c481
Compare
bdice
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
Looks good to me. Before merging, please update the changelog (see the PR checklist for more info). Also the documentation should be reviewed for anything that should be changed.
bdice
reviewed
Jun 14, 2022
bdice
added a commit
that referenced
this pull request
Aug 1, 2022
* Changed prefix to --prefix to make the argument optional. Changed the duplicate view in test. Still need to add tests * Added shorthand notation to view parser * Added skeleton for test_view_prefix * Extended test_view_incomplete_path_spec to test -p and --prefix * Fixes * Added test for optional prefix view * Added name to contributors * Update tests/test_shell.py Co-authored-by: Bradley Dice <[email protected]>
bdice
added a commit
that referenced
this pull request
Oct 7, 2022
* Changed prefix to --prefix to make the argument optional. Changed the duplicate view in test. Still need to add tests * Added shorthand notation to view parser * Added skeleton for test_view_prefix * Extended test_view_incomplete_path_spec to test -p and --prefix * Fixes * Added test for optional prefix view * Added name to contributors * Update tests/test_shell.py Co-authored-by: Bradley Dice <[email protected]>
bdice
added a commit
that referenced
this pull request
Oct 27, 2022
* Changed prefix to --prefix to make the argument optional. Changed the duplicate view in test. Still need to add tests * Added shorthand notation to view parser * Added skeleton for test_view_prefix * Extended test_view_incomplete_path_spec to test -p and --prefix * Fixes * Added test for optional prefix view * Added name to contributors * Update tests/test_shell.py Co-authored-by: Bradley Dice <[email protected]>
vyasr
pushed a commit
that referenced
this pull request
Oct 30, 2022
* Changed prefix to --prefix to make the argument optional. Changed the duplicate view in test. Still need to add tests * Added shorthand notation to view parser * Added skeleton for test_view_prefix * Extended test_view_incomplete_path_spec to test -p and --prefix * Fixes * Added test for optional prefix view * Added name to contributors * Update tests/test_shell.py Co-authored-by: Bradley Dice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I changed the CLI
viewargument to establish a path to be a flag rather than a positional argument. Added a test to check this change and altered another test that hadsignac view view pathand changed it to justsignac view path.Motivation and Context
Fixes issue #653.
Checklist: