Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move syncutil code into sync.py. #869

Merged
merged 5 commits into from
Dec 8, 2022
Merged

Move syncutil code into sync.py. #869

merged 5 commits into from
Dec 8, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 6, 2022

Description

This PR merges the syncutil and sync modules.

Motivation and Context

The code in syncutil is only every used by sync, so removing this indirection makes the code more discoverable by removing an unnecessary layer of indirection.

Checklist:

@vyasr vyasr added this to the v2.0.0 milestone Dec 6, 2022
@vyasr vyasr self-assigned this Dec 6, 2022
@vyasr vyasr requested review from a team as code owners December 6, 2022 04:37
@vyasr vyasr requested review from bdice and Charlottez112 and removed request for a team December 6, 2022 04:37
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #869 (8edb7ae) into master (35b862f) will decrease coverage by 0.01%.
The diff coverage is 80.29%.

@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
- Coverage   86.52%   86.51%   -0.02%     
==========================================
  Files          40       39       -1     
  Lines        4527     4522       -5     
  Branches      901      901              
==========================================
- Hits         3917     3912       -5     
  Misses        429      429              
  Partials      181      181              
Impacted Files Coverage Δ
signac/sync.py 81.43% <80.29%> (-1.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps consider reducing visibility of some public utility methods/classes.

signac/sync.py Outdated Show resolved Hide resolved
@vyasr vyasr merged commit 16a33c7 into master Dec 8, 2022
@vyasr vyasr deleted the refactor/merge_sync branch December 8, 2022 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants