-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 and limit MacOS/Window's tests. #957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are fixes for the failing CI.
Co-authored-by: Joshua A. Anderson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #957 +/- ##
==========================================
+ Coverage 85.63% 85.65% +0.01%
==========================================
Files 20 20
Lines 3461 3464 +3
Branches 758 759 +1
==========================================
+ Hits 2964 2967 +3
Misses 338 338
Partials 159 159 ☔ View full report in Codecov by Sentry. |
a3cf696
to
dede4d6
Compare
a86c8d2
to
6fb60ff
Compare
6fb60ff
to
37bcbf7
Compare
@joaander is there a way to get the CI to test both 'newest' and 'minimal' for Python 3.12 and Ubuntu? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any obvious problems in a short review.
I like the idea Josh proposed about the default key but don't have time to test it.
Co-authored-by: Bradley Dice <[email protected]>
c387a7e
to
4b96920
Compare
4b96920
to
8e5a4d3
Compare
A more specific filter is needed to avoid excluding internal deprecation warnings as errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Add Python 3.12 to CI testing and reduce non-Ubuntu runners to just oldest, minimal, and newest tests.
Motivation and Context
Checklist: