Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 and limit MacOS/Window's tests. #957

Merged
merged 25 commits into from
Dec 5, 2023
Merged

Conversation

b-butler
Copy link
Member

@b-butler b-butler commented Nov 14, 2023

Description

Add Python 3.12 to CI testing and reduce non-Ubuntu runners to just oldest, minimal, and newest tests.

Motivation and Context

  • Add newest Python version to testing.
  • Reduce organization runners required for limited non-Linux OSes.

Checklist:

@b-butler b-butler requested review from a team as code owners November 14, 2023 15:21
@b-butler b-butler requested review from cbkerr and SchoeniPhlippsn and removed request for a team November 14, 2023 15:21
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are fixes for the failing CI.

.github/workflows/run-pytest.yml Outdated Show resolved Hide resolved
.github/workflows/run-pytest.yml Outdated Show resolved Hide resolved
b-butler and others added 2 commits November 14, 2023 11:43
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a62f06d) 85.63% compared to head (26a8519) 85.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
+ Coverage   85.63%   85.65%   +0.01%     
==========================================
  Files          20       20              
  Lines        3461     3464       +3     
  Branches      758      759       +1     
==========================================
+ Hits         2964     2967       +3     
  Misses        338      338              
  Partials      159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

signac/import_export.py Outdated Show resolved Hide resolved
@b-butler
Copy link
Member Author

@joaander is there a way to get the CI to test both 'newest' and 'minimal' for Python 3.12 and Ubuntu?

Copy link
Member

@cbkerr cbkerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any obvious problems in a short review.
I like the idea Josh proposed about the default key but don't have time to test it.

Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@b-butler b-butler merged commit ce3ea8b into main Dec 5, 2023
16 checks passed
@b-butler b-butler deleted the ci/python-3.12 branch December 5, 2023 15:58
@cbkerr cbkerr added this to the v2.2.0 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants