Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
I've experienced with esbuild-sass-plugin and esbuild for quite long time. I also work with rollup and rollup-plugin-postcss. My most wanted feature on
esbuild-sass-plugin
isnamedExports
.What is
namedExports
?Why
namedExport
?esbuild
fromrollup
.import { class_foo, class_bar } from 'my-scss-module.scss';
esbuild
+esbuild-sass-plugin
on development env,rollup
+rollup-plugin-postcss
for production build.Is this PR introduce breaking changes?
How to use
namedExports
?I've also add a new fixture to project
test/fixture/named-exports
and new e2e unit test..Hope this help.
Regards.