separate import from loading data #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't seem like the AppVeyor build failing has anything to do with the code... any ideas? |
|
Thanks for the PR. The AppVeyor build can be ignored as it's not setup yet. To confirm: there is no functional change, right? |
|
Right - for this PR all I did was separate out the image/base64/import helpers into a new feature called |
|
Thanks for merging it! FYI I didn't bump the version number, so if you have a continuous deployment setup, it'll need to be bumped first :) |
|
I don't bump the version number until the last minute. The CI setup clones directly from master. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #243