Add spectral_cube, glue-qt to devdeps; test py312 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhomeier
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 96.90% 96.68% -0.22%
==========================================
Files 18 18
Lines 1421 1448 +27
==========================================
+ Hits 1377 1400 +23
- Misses 44 48 +4 ☔ View full report in Codecov by Sentry. |
7 tasks
|
@dhomeier - want to trigger a new build? (glue-viz/glue#2477 is merged) |
|
All clear! |
astrofrog
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Astropy 6.0dev has removed a number of deprecated functions, breaking CI through spectral_cube, with a fix merged, but not released. Adding it to the git-installs for
devat least temporarily, and also adding glue-qt to keep sync'ed with glue-core. Finally throwing in a py312 test job.