Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with future glue-core changes #380

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

astrofrog
Copy link
Member

Companion to glue-viz/glue#2432 - this keeps compatibility with the older versions of glue-core but uses the new import if possible.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.05% ⚠️

Comparison is base (3b24faf) 86.65% compared to head (16bf655) 86.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
- Coverage   86.65%   86.61%   -0.05%     
==========================================
  Files          89       89              
  Lines        4940     4946       +6     
==========================================
+ Hits         4281     4284       +3     
- Misses        659      662       +3     
Files Changed Coverage Δ
glue_jupyter/app.py 85.64% <0.00%> (-1.21%) ⬇️
glue_jupyter/__init__.py 73.77% <100.00%> (+1.35%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astrofrog astrofrog merged commit 1e70916 into glue-viz:main Aug 10, 2023
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant