Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with adjusting min/max values for size and cmap #395

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

Carifio24
Copy link
Member

Currently there are two issues with adjusting values for scatter layer options, both of which this PR fixes:

  • In linear (colormap) mode, the min and max values for the cmap can't be set from the widget. If the values are updated externally, the widget will update, but changing values from the widget has no effect (that is, the value in the state is not updated). The reason for this is that the deserialization line here catches cmap_vmin and cmap_vmax as well as cmap.
  • The text fields used for the min/max size values in linear size mode (and those for the colormap after the above issue is fixed) update the state values to be strings rather than numbers. I think the correct fix for this (which this PR applies) is to use the glue-float-field component for handling these values.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c98cb9d) 87.33% compared to head (4d611ee) 87.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage   87.33%   87.33%           
=======================================
  Files          89       89           
  Lines        5013     5013           
=======================================
  Hits         4378     4378           
  Misses        635      635           
Files Changed Coverage Δ
glue_jupyter/state_traitlets_helpers.py 85.57% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhomeier dhomeier added bug Something isn't working ui labels Aug 31, 2023
@dhomeier dhomeier merged commit 83aeb3a into glue-viz:main Aug 31, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants