Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define fileno() on GlueLogger for ipykernel 6+ #2206

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

astrofrog
Copy link
Member

Fixes compatibility with ipykernel 6+ (see ipython/ipykernel#630)

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #2206 (136b4e1) into master (d7dedb5) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2206      +/-   ##
==========================================
- Coverage   88.01%   88.00%   -0.01%     
==========================================
  Files         247      247              
  Lines       22966    22968       +2     
==========================================
+ Hits        20213    20214       +1     
- Misses       2753     2754       +1     
Impacted Files Coverage Δ
glue/app/qt/application.py 78.57% <50.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7dedb5...136b4e1. Read the comment docs.

@astrofrog astrofrog merged commit ad14432 into glue-viz:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant