Siddharthvipul/parsers #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
siddharthvipul
commented
Jun 4, 2018
siddharthvipul
commented
- empty directories (holders) for other tools
- add smallfile parser
- add sample output of smallfile (read and write)
- add sample output of the parser
nigelbabu
suggested changes
Jun 4, 2018
| log to stderr? : False | ||
| ext.attr.size : 0 | ||
| ext.attr.count : 0 | ||
| host = dhcp37-55.lab.eng.blr.redhat.com,thr = 00,elapsed = 22.428904,files = 1000,records = 1000,status = ok |
There was a problem hiding this comment.
Remove all references to internal IPs in public code.
| @@ -0,0 +1,84 @@ | |||
| #!/usr/bin/python3 | |||
There was a problem hiding this comment.
make parsers a python module and fix names appropriately.
| attr = [] | ||
| with open(file_name) as fobj: | ||
| data_file = fobj.read().split("\n") | ||
| for line in data_file: |
There was a problem hiding this comment.
Have you looked at whether smallfile already outputs CSV and if you can use that instead?
There was a problem hiding this comment.
With th option --output-json smallfile will output JSON data, this maybe more useful from a parsing standpoint.
smallfile does output csv, but that is more for when we give --response-times option, and records response times for each operation. Noting that here. Also, we possibly do not need that.
I would prefer parsing JSON in this case, rather than CLI output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.