Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow version numbers that start with 23 or 24 #49

Closed
wants to merge 1 commit into from
Closed

allow version numbers that start with 23 or 24 #49

wants to merge 1 commit into from

Conversation

t0nghe
Copy link

@t0nghe t0nghe commented Jan 23, 2024

Description

On Anki version 23.10 and onwards, “Syntax Highlighting for Code” addon fails to load. This is due to addon_path not being correctly handled.

This bug is fixed by allowing version numbers that start with 23 and 24.

Checklist:

Please replace the space inside the brackets with an x and fill out the ellipses if the following items apply:

  • I've read and understood the contribution guidelines
  • I've tested my changes against at least one of the following Anki builds:
    • Latest standard Anki 23.12.1 binary build
    • Latest standard Anki 2.1 binary build [required for Anki-compatible 2.1 add-ons]
    • Latest alternative Anki 2.1 binary build
    • Latest Anki 2.0 binary build [required for Anki 2.0-compatible add-ons]
  • I've tested my changes on at least one of the following platforms:
    • Linux, version:
    • Windows, version:
    • macOS, version: 13.0.1
  • My changes potentially affect non-desktop platforms, of which I've tested:
    • AnkiMobile, version:
    • AnkiDroid, version:
    • AnkiWeb

@t0nghe
Copy link
Author

t0nghe commented Jan 23, 2024

PR #47 does the same thing and it seems better.

@t0nghe t0nghe closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant