CSUB-1232: Remove collect coins

[beqaabu]

Description of proposed changes

Removing collect_coins functionality. Everything is commented out for now not deleted. The only part left to figure out is the migrations. The node compiles, the tests are green

Practical tips for PR review & merge:

• All GitHub Actions report PASS
• Newly added code/functions have unit tests
  • Coverage tools report all newly added lines as covered
  • The positive scenario is exercised
  • Negative scenarios are exercised, e.g. assert on all possible errors
  • Assert on events triggered if applicable
  • Assert on changes made to storage if applicable
• Modified behavior/functions - try to make sure above test items are covered
• Integration tests are added if applicable/needed

[github-actions]

For full LLVM coverage report click here!

[atodorov]

Added some comments and questions

[atodorov]

Minor comments, otherwise looks good.

[atodorov]

For some reason compiling unit tests is failing:

error[E0275]: overflow evaluating the requirement `<Runtime as pallet_grandpa::Config>::KeyOwnerProof == _`

https://github.com/gluwa/creditcoin/actions/runs/10282472003/job/28455986492?pr=1660

[beqaabu]

For some reason compiling unit tests is failing:

error[E0275]: overflow evaluating the requirement `<Runtime as pallet_grandpa::Config>::KeyOwnerProof == _`

https://github.com/gluwa/creditcoin/actions/runs/10282472003/job/28455986492?pr=1660

saw this gluwa/creditcoin3@1655f7d and this paritytech/polkadot-sdk#2641 and then I remembered when we fixed this issue on cc3, probably needs the same fix here, @atodorov WDYT?

[atodorov]

saw this gluwa/creditcoin3@1655f7d and this paritytech/polkadot-sdk#2641 and then I remembered when we fixed this issue on cc3, probably needs the same fix here, @atodorov WDYT?

I think it is safer and faster to revert the change to rust-toolchain.toml instead.

[atodorov]

• cargo audit - unrelated failure, known issue
• build-creditcoin-transaction-producer - unrelated failure, known issue
• llvm cov - fails with not enough disk space on a GitHub hosted runner. This is new but not convinced it is entirely related to the current changes. cargo test appears to be passing -> https://pastebin.com/iJkEbE50

LGTM