Skip to content

Commit

Permalink
added shell_unittests and ui_unittests to the testing menu (flutter#5…
Browse files Browse the repository at this point in the history
…5711)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
  • Loading branch information
gaaclarke authored Oct 8, 2024
1 parent 7d4b6d4 commit 167a42e
Show file tree
Hide file tree
Showing 2 changed files with 96 additions and 0 deletions.
72 changes: 72 additions & 0 deletions engine.code-workspace
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,24 @@
]
}
},
{
"name": "shell_unittests_arm64",
"pattern": "../out/host_debug_unopt_arm64/shell_unittests",
"runTask": {
"before": [
"shell_unittests_arm64"
]
}
},
{
"name": "ui_unittests_arm64",
"pattern": "../out/host_debug_unopt_arm64/ui_unittests",
"runTask": {
"before": [
"ui_unittests_arm64"
]
}
},
{
"name": "impeller_golden_tests_arm64",
"pattern": "../out/host_debug_unopt_arm64/impeller_golden_tests",
Expand Down Expand Up @@ -291,6 +309,60 @@
"//flutter/display_list:display_list_unittests"
]
},
{
"type": "shell",
"command": "./flutter/bin/et",
"options": {
"cwd": "${workspaceFolder}/.."
},
"problemMatcher": [
"$gcc"
],
"presentation": {
"echo": true,
"reveal": "silent",
"focus": false,
"panel": "shared",
"clear": true
},
"group": {
"kind": "build"
},
"label": "shell_unittests_arm64",
"args": [
"build",
"-c",
"host_debug_unopt_arm64",
"//flutter/shell:shell_unittests"
]
},
{
"type": "shell",
"command": "./flutter/bin/et",
"options": {
"cwd": "${workspaceFolder}/.."
},
"problemMatcher": [
"$gcc"
],
"presentation": {
"echo": true,
"reveal": "silent",
"focus": false,
"panel": "shared",
"clear": true
},
"group": {
"kind": "build"
},
"label": "ui_unittests_arm64",
"args": [
"build",
"-c",
"host_debug_unopt_arm64",
"//flutter/lib/ui:ui_unittests"
]
},
{
"type": "shell",
"command": "./flutter/bin/et",
Expand Down
24 changes: 24 additions & 0 deletions tools/vscode_workspace/engine-workspace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,16 @@ settings:
runTask:
before:
- display_list_unittests_arm64
- name: shell_unittests_arm64
pattern: ../out/host_debug_unopt_arm64/shell_unittests
runTask:
before:
- shell_unittests_arm64
- name: ui_unittests_arm64
pattern: ../out/host_debug_unopt_arm64/ui_unittests
runTask:
before:
- ui_unittests_arm64
- name: impeller_golden_tests_arm64
pattern: ../out/host_debug_unopt_arm64/impeller_golden_tests
runTask:
Expand Down Expand Up @@ -210,6 +220,20 @@ tasks:
- -c
- host_debug_unopt_arm64
- //flutter/display_list:display_list_unittests
- <<: *et-task
label: shell_unittests_arm64
args:
- build
- -c
- host_debug_unopt_arm64
- //flutter/shell:shell_unittests
- <<: *et-task
label: ui_unittests_arm64
args:
- build
- -c
- host_debug_unopt_arm64
- //flutter/lib/ui:ui_unittests
- <<: *et-task
label: impeller_golden_tests_arm64
args:
Expand Down

0 comments on commit 167a42e

Please sign in to comment.