Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internals] Module should be a record or an interface implemented by one #1382

Closed
altrisi opened this issue Apr 2, 2022 · 3 comments · Fixed by #1383
Closed

[Internals] Module should be a record or an interface implemented by one #1382

altrisi opened this issue Apr 2, 2022 · 3 comments · Fixed by #1383
Labels
scarpet Issues related to scarpet in some way

Comments

@altrisi
Copy link
Collaborator

altrisi commented Apr 2, 2022

Right now there's a distinction between Module (base abstract class), BundledModule and FileModule. However, the only difference between them is that they have different static methods around.

They should be converted to either a record, or an interface with a record implementation, with the current constructors being converted to just factory methods.
@altrisi
Copy link
Collaborator Author

altrisi commented Apr 2, 2022 •
edited
Loading

I'd say preferrably a record given a Module's data is not expected to be changed by the implementations that use them, and may become problematic if someone decides to do such changes.

@altrisi
Copy link
Collaborator Author

altrisi commented Apr 2, 2022 •
edited
Loading

Binary safety: BundledModule has a public constructor, that would cause issues if some extension is depending on it instead of using the factory methods. Same for FileModule. And the factory methods in BundledModule return a BundledModule instead of just a module :(

TL;DR: Binary compatibility is difficult.

@altrisi
Copy link
Collaborator Author

altrisi commented Apr 2, 2022 •
edited
Loading

Actually we can just make a new type and provide a fallback for those types, it shouldn't be that bad, and preferable given else the carpet.script.bundled package would only have a single class...

@altrisi altrisi mentioned this issue Apr 2, 2022
Merged
@altrisi altrisi changed the title [Internals] Module should be a record or an interface [Internals] Module should be a record or an interface implemented by one Apr 2, 2022
@altrisi altrisi added the scarpet Issues related to scarpet in some way label Apr 4, 2022
altrisi added a commit that referenced this issue Jul 25, 2022
@altrisi
Remove old deprecated Module type and subtypes
b677cd7 
They were deprecated in #1382
Ghoulboy78 added a commit to Ghoulboy78/fabric-carpet that referenced this issue Aug 5, 2022
@Ghoulboy78
Squashed commit of the following:
90a4c47 
commit 5b720cb
Author: altrisi <[email protected]>
Date:   Mon Jul 25 23:56:31 2022 +0200

    Don't add `Mod` to CF release to prevent cutting game version

commit feb0dc1
Author: altrisi <[email protected]>
Date:   Fri Jul 29 14:26:00 2022 +0200

    Remove another duplicated mixin entry

    This time for `DistanceManager_spawnChunksMixin`

commit f2a270b
Author: altrisi <[email protected]>
Date:   Fri Jul 29 13:57:32 2022 +0200

    Remove duplicated mixin entry for `ServerLevel_spawnChunksMixin`

commit da06e30
Author: altrisi <[email protected]>
Date:   Fri Jul 29 13:12:26 2022 +0200

    Minor SpawnReporter cleanup (gnembon#1517)

    Mostly removes unused methods

commit 8f7e453
Author: altrisi <[email protected]>
Date:   Fri Jul 29 13:12:09 2022 +0200

    Resolve raw type warnings (gnembon#1516)

    Also very small optimization to hopper counters and removal of redundant casts in `PerimeterDiagnostics`

commit be3c7f2
Author: gnembon <[email protected]>
Date:   Wed Jul 27 22:33:18 2022 +0200

    1.4.83

commit ab45b6f
Author: gnembon <[email protected]>
Date:   Wed Jul 27 22:32:26 2022 +0200

    1.19.1

commit b677cd7
Author: altrisi <[email protected]>
Date:   Mon Jul 25 22:35:24 2022 +0200

    Remove old deprecated `Module` type and subtypes

    They were deprecated in gnembon#1382

commit 97c4cc9
Author: altrisi <[email protected]>
Date:   Mon Jul 25 21:59:50 2022 +0200

    Simplify threading and networking in `download` suggester (gnembon#1512)

    * Simplify threading in download suggester
    This also makes it more robust against race conditions

    * Simplify network requests around app store

commit c08d857
Author: altrisi <[email protected]>
Date:   Sat Jul 23 23:56:13 2022 +0200

    Don't refresh local app store repo on world change

    Relates to gnembon#1508.

commit 6215f83
Author: gnembon <[email protected]>
Date:   Fri Jul 22 18:34:04 2022 +0200

    1.4.82

commit 6d3c4fa
Author: gnembon <[email protected]>
Date:   Fri Jul 22 18:25:43 2022 +0200

    1.19.1-rc2

commit 86ac49c
Author: altrisi <[email protected]>
Date:   Thu Jul 21 15:33:42 2022 +0200

    Fix autocomplete removing all upper-case letters in `script run`

commit a38cd09
Author: ch-yx <[email protected]>
Date:   Thu Jul 21 21:15:30 2022 +0800

    One-line fix for a minor bug about encoding  (gnembon#1368)

commit 0f474f3
Author: Space Walker <[email protected]>
Date:   Thu Jul 21 15:13:20 2022 +0200

    Fix gnembon#1492 (gnembon#1493)

commit c2788f0
Author: altrisi <[email protected]>
Date:   Thu Jul 21 15:12:58 2022 +0200

    Allow modded structures in overlay's `structure` renderer (gnembon#1504)

commit 14325d7
Author: Ghoulboy <[email protected]>
Date:   Thu Jul 21 15:12:44 2022 +0200

    Set ambient properly in modify(entity, 'effect') (gnembon#1501)

commit c919a8c
Author: gnembon <[email protected]>
Date:   Thu Jul 14 00:59:13 2022 +0200

    1.4.81

commit 544857d
Author: gnembon <[email protected]>
Date:   Thu Jul 14 00:57:49 2022 +0200

    1.19.1-pre4

commit 74f56c1
Author: Crec0 <[email protected]>
Date:   Thu Jul 7 02:59:28 2022 -0700

    Fix `query(e, 'brain', 'visible_mobs')` returning null (gnembon#1481)

commit 5a4ceb6
Author: altrisi <[email protected]>
Date:   Thu Jul 7 11:45:37 2022 +0200

    Fix language fallbacks for rules not being available early

    Fixes gnembon#1483

commit d571d61
Author: gnembon <[email protected]>
Date:   Tue Jul 5 10:39:23 2022 +0200

    hmm

commit 8748c7c
Author: gnembon <[email protected]>
Date:   Tue Jul 5 10:22:32 2022 +0200

    1.4.80

commit 0a00734
Author: gnembon <[email protected]>
Date:   Tue Jul 5 10:21:26 2022 +0200

    1.19.1-pre2

commit 6019f81
Author: Ghoulboy <[email protected]>
Date:   Mon Jun 27 20:37:44 2022 +0200

    Making portal_timer and portal_cooldown return portal timer and portal cooldown in that order (gnembon#1476)

    * This error is so dumb I must have done it

    * Update ai_tracker.sc

commit ee4bc33
Author: altrisi <[email protected]>
Date:   Mon Jun 27 14:30:34 2022 +0200

    Remove catchall in action pack update

    Resolves gnembon#1446.

commit b0c94bc
Author: altrisi <[email protected]>
Date:   Mon Jun 27 14:11:20 2022 +0200

    Remove unused `CarpetServer.rand` field

    Resolves gnembon#1429.

commit 41991b0
Author: altrisi <[email protected]>
Date:   Mon Jun 27 14:09:03 2022 +0200

    Improve error message when commands fail to be added and make commands using the new system check for masking (gnembon#1404)

    * Improve error message when command already exists

    * Add app's name to the message

    * Add app name to any command load failure and fix commands from new system masking existing ones

    * Fix duplicated app name in an error

    * Update to recent snapshot changes

commit 286dbea
Author: Fx Morin <[email protected]>
Date:   Mon Jun 27 08:04:11 2022 -0400

    Logger Improvements (gnembon#1399)

    * Null checks & using getOptions

    * Removed useless variable, and made HashMap's final

    * This list & Map should not be modified.
    Plus small changes

    * Small things

    * Fix gnembon#1398

    * Apply suggestions from code review

    * Remove Dead call

    * Handle options being null

    * Remove redundant field explainers

    Those were there for when they were intermediary fields, they now have a proper name

commit 0a972d6
Author: altrisi <[email protected]>
Date:   Mon Jun 27 13:12:15 2022 +0200

    Settings rework and encapsulation (gnembon#1330)

    * Settings rework and encapsulation

    * Settings overhaul 3

    Move everything in the new system to a new API package

    Require rules using the new system to specify descriptions in their translation files

    Implement temporary system on top of current translations to allow that to work properly

    * Fix getRules fallback

    * Final touches to settings refactor

    * Mention that set shouldn't throw and remove comment

    * Change translation keys to unify with translation PR

    * Deprecate printAllRulesToLog to allow using any PrintStream

    * Remove restriction of CarpetRules being Comparable

    And fix overreaction in a deprecation message

    * Bring back user input to rule observers

    * Make Validator deprecation warning not spam on use

    * Remove unneeded abstract methods in CarpetRule already inherited from CarpetRule

    They literally do nothing, don't even force them to be implemented, and may be confusing as to why they're there or as if they are needed to be implemented

    * Fix legacy SettingsManager field not being assigned correctly

    * Finish fixing conflicts from future merge

    * Actually fix remaining conflicts from future merge (missing imports)

    * Import the newer rule in SettingsManager

    * Refactor Validators

    * Don't spam deprecation warnings on custom managers

    * Get out the var

    * Fix missing warning in old rule observers

    * Update src/main/java/carpet/api/settings/Rule.java

    * Remove `@ApiStatus.Experimental` annotations

    * Fix incorrect `@deprecated` javadoc tags

    By removing them given the class is deprecated anyway and else there's too much noise

    * Add missing static import

    * Remove TypedField and use a regular field

    I liked that class tbh, but it's true that it wasn't really needed

    * Move `field` assignment out of for removal

    * Fix not following contract of `type()` returning boxed value

    Previously handled by TypedField

    * Fix few incorrect translation keys

    * Remove resaving of comments when saving config files

    Comments ignoring is still a thing when reading, so `locked` configs for example will keep comments

    * Condense rule load messages in one

    * Only print loaded settings message when at least one setting was changed

    * Fix legacy validator detector

    * Tweak and add more context to response to invalid values

    * Fix strict validator not actually erroring on invalid input

commit f5a92eb
Author: gnembon <[email protected]>
Date:   Wed Jun 15 22:30:25 2022 +0200

    22w24a

commit 81d3b9e
Author: gnembon <[email protected]>
Date:   Tue Jun 7 17:41:02 2022 +0200

    curse

commit 5e5815c
Author: gnembon <[email protected]>
Date:   Tue Jun 7 17:37:35 2022 +0200

    1.19

commit 140cb15
Author: altrisi <[email protected]>
Date:   Wed Jun 1 22:37:39 2022 +0200

    Make newline in release message using zero-width character

    (​)

commit f0fbe32
Author: Dainternetdude <[email protected]>
Date:   Tue Apr 19 13:30:12 2022 -0600

    spelling

commit 486c2ec
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Jun 1 20:19:32 2022 +0000

    Merge docs for 'Carpet Mod 1.4.78 for 1.19-prerelease-5'

commit 7de976a
Author: Space Walker <[email protected]>
Date:   Wed Jun 1 04:39:22 2022 +0200

    fix gnembon#1454

commit 40af4f2
Author: gnembon <[email protected]>
Date:   Wed Jun 1 21:58:32 2022 +0200

    1.4.78 for 1.19-pre5

commit c10149b
Author: altrisi <[email protected]>
Date:   Sat May 28 13:07:08 2022 +0200

    Publish changelogs to Discord when releasing (gnembon#1428)

    Co-authored-by: Crec0 <[email protected]>

commit 8c7dfa1
Author: Luca Bertozzi <[email protected]>
Date:   Fri May 27 20:24:25 2022 +0200

    Added `__on_chunk_unloaded` scarpet event (gnembon#1451)

    * Fixes gnembon#1403

    * Use concrete type

commit d088ee4
Author: altrisi <[email protected]>
Date:   Fri May 27 19:44:39 2022 +0200

    Set mixin compatibility level to Java 17

commit f18cfb0
Author: altrisi <[email protected]>
Date:   Fri May 27 19:43:45 2022 +0200

    Fix more warnings and do some small optimizations (gnembon#1356)

    * Fix more warnings and do some small optimizations

    * Fix more warnings in ValueConversions

    * Clean up some decompiler names and fix an unnecessary transformation around commands

    * Use (way) more compact data structure for slot map

    * Minor tweaks
    Such as map directly in the collector

    * I hate vanilla javac
    Revert map changes in latest commit

commit e4dc080
Author: altrisi <[email protected]>
Date:   Tue May 24 15:26:31 2022 +0200

    Bump Loader requirement in `fabric.mod.json` too

commit fc54a87
Author: gnembon <[email protected]>
Date:   Mon May 23 23:07:33 2022 +0200

    1.4.77

commit 3a9e3b3
Author: gnembon <[email protected]>
Date:   Mon May 23 23:06:27 2022 +0200

    1.19-pre2

commit 08a6590
Author: altrisi <[email protected]>
Date:   Fri May 20 20:10:32 2022 +0200

    Remove `updateSuppressionCrashFix` and related logger (gnembon#1445)

commit b0a2f2c
Author: gnembon <[email protected]>
Date:   Wed May 18 21:10:15 2022 +0200

    1.4.76

commit 2af763d
Author: gnembon <[email protected]>
Date:   Wed May 18 21:08:32 2022 +0200

    1.19-pre1

commit bbe7701
Author: altrisi <[email protected]>
Date:   Tue May 17 22:06:49 2022 +0200

    Autogenerate refmap field in mixins json and remove empty `server` field

    Not explicitly specifying the refmap here also removes the log entry in dev environments where Mixin complains about missing refmap.

commit 668f309
Author: altrisi <[email protected]>
Date:   Tue May 17 21:55:22 2022 +0200

    Change missed usage of deprecated methods from gnembon#1383

commit 9daf72b
Author: Fx Morin <[email protected]>
Date:   Tue May 17 15:21:46 2022 -0400

    Update `updateSuppressionBlock` for 1.19 (gnembon#1401)

    * Changed Rule: `updateSuppressionBlock` to match new update suppression

    * Make it easier to use

    * Carpets mixin file will be the death of me

    * Renamed `WorldInterface` to `LevelInterface`
    Merged LevelAccessor with LevelInterface

    * Fix issues with 22w14a & resolve issues

    * Add `@Unique` to Level_tickMixin.java

    * Naming, brackets, and description

    * Return null on invalid

    * Fix remaining refactoring issues

commit a60bc38
Author: altrisi <[email protected]>
Date:   Tue May 17 20:11:49 2022 +0200

    Refactor `Module` into a single record type and fix system globals (gnembon#1383)

commit d681cb4
Author: gnembon <[email protected]>
Date:   Fri May 13 11:28:01 2022 +0200

    1.4.75

commit 1a6b1df
Author: gnembon <[email protected]>
Date:   Fri May 13 11:26:47 2022 +0200

    22w19a

commit 648ea01
Author: Ghoulboy <[email protected]>
Date:   Wed May 11 19:56:25 2022 +0200

    Making deepslate generate below y=0, not y=16 (gnembon#1433)

    * Fixes gnembon#1431

    * Updating carpet rule description

    * Making it work for cobbled deepslate

commit e5a3cdf
Author: gnembon <[email protected]>
Date:   Wed May 4 21:35:15 2022 +0200

    1.4.74

commit 217567c
Author: gnembon <[email protected]>
Date:   Wed May 4 21:34:22 2022 +0200

    22w18a

commit 544c1a8
Author: Crec0 <[email protected]>
Date:   Sun May 1 03:29:04 2022 -0700

    Profile categories splitting and descriptions. (gnembon#1375)

    * Split spawning and random ticks into separate categories

    * Split blocks into tile ticks and block events

    * Fix ambiguous call to tick() method
    Fix package private warning

    * fix: add missing sections for tile ticks and block events

    * fix: wrong profiling order

    * feat: add descriptions to profiler categories

    * refactor: replace guava ImmutableMap with jdk Map

    * fix negative time in "rest" category

commit 4662a86
Author: altrisi <[email protected]>
Date:   Fri Apr 29 20:16:03 2022 +0200

    Delete unused `BiomeArrayInterface`

commit c2c127b
Author: gnembon <[email protected]>
Date:   Wed Apr 27 20:17:56 2022 +0200

    1.4.73

commit fc8114b
Author: gnembon <[email protected]>
Date:   Wed Apr 27 20:16:56 2022 +0200

    added 'xpFromExplosions' for xp to always drop from exploding blocks

commit aaf8e7e
Author: gnembon <[email protected]>
Date:   Wed Apr 27 19:51:37 2022 +0200

    22w17a

commit 6111dec
Author: altrisi <[email protected]>
Date:   Thu Mar 17 21:21:44 2022 +0100

    Ease concrete restrictions on Annotated Scarpet API and make instantiating lazy

    Prevents instantiating classes with all annotated methods static, making it also more flexible in that you can put annotated functions near to other API that may be initialized

commit aafb740
Author: altrisi <[email protected]>
Date:   Sun Apr 24 13:30:55 2022 +0200

    Refactor BlockRotator (gnembon#1362)

    - Removes the unused accurate block placement protocol that has been dead there for ages
    - Removes the various rotate clockwise methods in favour of Direction's, that did exactly the same

    No behaviour changes

commit 8346199
Author: Crec0 <[email protected]>
Date:   Sun Apr 24 03:20:39 2022 -0700

    Fix "Unable to determine descriptor" warnings by setting `remap=false` at some locations. (gnembon#1423)

    * set remap=false for "Unable to determine descriptor" warnings

    * remove suppressWarning annotation

commit c1141dd
Author: altrisi <[email protected]>
Date:   Thu Apr 21 18:02:22 2022 +0200

    Fix latest commit about publishing, forgot a few blocks...

commit 91fbb44
Author: altrisi <[email protected]>
Date:   Thu Apr 21 18:00:22 2022 +0200

    Fix publishing warn, go back to loom 0.11 as 0.12 is not yet recommended

    See FabricMC/fabric-example-mod@8adede0

commit 127f4bb
Author: Fx Morin <[email protected]>
Date:   Thu Apr 21 02:17:47 2022 -0400

    Fix carpet not building by updating loom (gnembon#1422)

    * Attempt to fix github issue

commit d03900a
Author: gnembon <[email protected]>
Date:   Thu Apr 21 00:30:35 2022 +0200

    1.4.72

commit 746c854
Author: gnembon <[email protected]>
Date:   Thu Apr 21 00:26:39 2022 +0200

    22w16b with massive Component changes

commit 8101abb
Author: gnembon <[email protected]>
Date:   Wed Apr 20 23:19:59 2022 +0200

    retire extreme behaviours, added moreBlueSkulls

commit b2cb70c
Author: altrisi <[email protected]>
Date:   Wed Apr 20 14:57:50 2022 +0200

    Remove cotton maven given lQF is now on the Gradle plugin portal (gnembon#1420)

    * Bump QuilfFlower version

    * Remove cotton maven given loom QuiltFlower is now in the Gradle plugin portal

commit 8c2ded4
Author: altrisi <[email protected]>
Date:   Wed Apr 20 13:50:44 2022 +0200

    Simplify mod initializers and prevent extensions from mixing into Carpet just to register themselves (gnembon#1396)

commit 83b0fb1
Author: altrisi <[email protected]>
Date:   Wed Apr 20 13:29:31 2022 +0200

    Show local type in exception hover tooltips (gnembon#1397)

commit 80a5342
Author: altrisi <[email protected]>
Date:   Wed Apr 20 13:27:25 2022 +0200

    Make scarpet internal and control flow exceptions stackless (gnembon#1392)

commit 7686147
Author: altrisi <[email protected]>
Date:   Wed Apr 20 13:01:58 2022 +0200

    Add support for formatted names in `create_marker` (gnembon#1413)
Ghoulboy78 added a commit to Ghoulboy78/fabric-carpet that referenced this issue Aug 5, 2022
@Ghoulboy78
Squashed commit of the following:
6c1b2db 
commit 5b720cb
Author: altrisi <[email protected]>
Date:   Mon Jul 25 23:56:31 2022 +0200

    Don't add `Mod` to CF release to prevent cutting game version

commit feb0dc1
Author: altrisi <[email protected]>
Date:   Fri Jul 29 14:26:00 2022 +0200

    Remove another duplicated mixin entry

    This time for `DistanceManager_spawnChunksMixin`

commit f2a270b
Author: altrisi <[email protected]>
Date:   Fri Jul 29 13:57:32 2022 +0200

    Remove duplicated mixin entry for `ServerLevel_spawnChunksMixin`

commit da06e30
Author: altrisi <[email protected]>
Date:   Fri Jul 29 13:12:26 2022 +0200

    Minor SpawnReporter cleanup (gnembon#1517)

    Mostly removes unused methods

commit 8f7e453
Author: altrisi <[email protected]>
Date:   Fri Jul 29 13:12:09 2022 +0200

    Resolve raw type warnings (gnembon#1516)

    Also very small optimization to hopper counters and removal of redundant casts in `PerimeterDiagnostics`

commit be3c7f2
Author: gnembon <[email protected]>
Date:   Wed Jul 27 22:33:18 2022 +0200

    1.4.83

commit ab45b6f
Author: gnembon <[email protected]>
Date:   Wed Jul 27 22:32:26 2022 +0200

    1.19.1

commit b677cd7
Author: altrisi <[email protected]>
Date:   Mon Jul 25 22:35:24 2022 +0200

    Remove old deprecated `Module` type and subtypes

    They were deprecated in gnembon#1382

commit 97c4cc9
Author: altrisi <[email protected]>
Date:   Mon Jul 25 21:59:50 2022 +0200

    Simplify threading and networking in `download` suggester (gnembon#1512)

    * Simplify threading in download suggester
    This also makes it more robust against race conditions

    * Simplify network requests around app store

commit c08d857
Author: altrisi <[email protected]>
Date:   Sat Jul 23 23:56:13 2022 +0200

    Don't refresh local app store repo on world change

    Relates to gnembon#1508.

commit 6215f83
Author: gnembon <[email protected]>
Date:   Fri Jul 22 18:34:04 2022 +0200

    1.4.82

commit 6d3c4fa
Author: gnembon <[email protected]>
Date:   Fri Jul 22 18:25:43 2022 +0200

    1.19.1-rc2

commit 86ac49c
Author: altrisi <[email protected]>
Date:   Thu Jul 21 15:33:42 2022 +0200

    Fix autocomplete removing all upper-case letters in `script run`

commit a38cd09
Author: ch-yx <[email protected]>
Date:   Thu Jul 21 21:15:30 2022 +0800

    One-line fix for a minor bug about encoding  (gnembon#1368)

commit 0f474f3
Author: Space Walker <[email protected]>
Date:   Thu Jul 21 15:13:20 2022 +0200

    Fix gnembon#1492 (gnembon#1493)

commit c2788f0
Author: altrisi <[email protected]>
Date:   Thu Jul 21 15:12:58 2022 +0200

    Allow modded structures in overlay's `structure` renderer (gnembon#1504)

commit 14325d7
Author: Ghoulboy <[email protected]>
Date:   Thu Jul 21 15:12:44 2022 +0200

    Set ambient properly in modify(entity, 'effect') (gnembon#1501)

commit c919a8c
Author: gnembon <[email protected]>
Date:   Thu Jul 14 00:59:13 2022 +0200

    1.4.81

commit 544857d
Author: gnembon <[email protected]>
Date:   Thu Jul 14 00:57:49 2022 +0200

    1.19.1-pre4

commit 74f56c1
Author: Crec0 <[email protected]>
Date:   Thu Jul 7 02:59:28 2022 -0700

    Fix `query(e, 'brain', 'visible_mobs')` returning null (gnembon#1481)

commit 5a4ceb6
Author: altrisi <[email protected]>
Date:   Thu Jul 7 11:45:37 2022 +0200

    Fix language fallbacks for rules not being available early

    Fixes gnembon#1483

commit d571d61
Author: gnembon <[email protected]>
Date:   Tue Jul 5 10:39:23 2022 +0200

    hmm

commit 8748c7c
Author: gnembon <[email protected]>
Date:   Tue Jul 5 10:22:32 2022 +0200

    1.4.80

commit 0a00734
Author: gnembon <[email protected]>
Date:   Tue Jul 5 10:21:26 2022 +0200

    1.19.1-pre2

commit 6019f81
Author: Ghoulboy <[email protected]>
Date:   Mon Jun 27 20:37:44 2022 +0200

    Making portal_timer and portal_cooldown return portal timer and portal cooldown in that order (gnembon#1476)

    * This error is so dumb I must have done it

    * Update ai_tracker.sc

commit ee4bc33
Author: altrisi <[email protected]>
Date:   Mon Jun 27 14:30:34 2022 +0200

    Remove catchall in action pack update

    Resolves gnembon#1446.

commit b0c94bc
Author: altrisi <[email protected]>
Date:   Mon Jun 27 14:11:20 2022 +0200

    Remove unused `CarpetServer.rand` field

    Resolves gnembon#1429.

commit 41991b0
Author: altrisi <[email protected]>
Date:   Mon Jun 27 14:09:03 2022 +0200

    Improve error message when commands fail to be added and make commands using the new system check for masking (gnembon#1404)

    * Improve error message when command already exists

    * Add app's name to the message

    * Add app name to any command load failure and fix commands from new system masking existing ones

    * Fix duplicated app name in an error

    * Update to recent snapshot changes

commit 286dbea
Author: Fx Morin <[email protected]>
Date:   Mon Jun 27 08:04:11 2022 -0400

    Logger Improvements (gnembon#1399)

    * Null checks & using getOptions

    * Removed useless variable, and made HashMap's final

    * This list & Map should not be modified.
    Plus small changes

    * Small things

    * Fix gnembon#1398

    * Apply suggestions from code review

    * Remove Dead call

    * Handle options being null

    * Remove redundant field explainers

    Those were there for when they were intermediary fields, they now have a proper name

commit 0a972d6
Author: altrisi <[email protected]>
Date:   Mon Jun 27 13:12:15 2022 +0200

    Settings rework and encapsulation (gnembon#1330)

    * Settings rework and encapsulation

    * Settings overhaul 3

    Move everything in the new system to a new API package

    Require rules using the new system to specify descriptions in their translation files

    Implement temporary system on top of current translations to allow that to work properly

    * Fix getRules fallback

    * Final touches to settings refactor

    * Mention that set shouldn't throw and remove comment

    * Change translation keys to unify with translation PR

    * Deprecate printAllRulesToLog to allow using any PrintStream

    * Remove restriction of CarpetRules being Comparable

    And fix overreaction in a deprecation message

    * Bring back user input to rule observers

    * Make Validator deprecation warning not spam on use

    * Remove unneeded abstract methods in CarpetRule already inherited from CarpetRule

    They literally do nothing, don't even force them to be implemented, and may be confusing as to why they're there or as if they are needed to be implemented

    * Fix legacy SettingsManager field not being assigned correctly

    * Finish fixing conflicts from future merge

    * Actually fix remaining conflicts from future merge (missing imports)

    * Import the newer rule in SettingsManager

    * Refactor Validators

    * Don't spam deprecation warnings on custom managers

    * Get out the var

    * Fix missing warning in old rule observers

    * Update src/main/java/carpet/api/settings/Rule.java

    * Remove `@ApiStatus.Experimental` annotations

    * Fix incorrect `@deprecated` javadoc tags

    By removing them given the class is deprecated anyway and else there's too much noise

    * Add missing static import

    * Remove TypedField and use a regular field

    I liked that class tbh, but it's true that it wasn't really needed

    * Move `field` assignment out of for removal

    * Fix not following contract of `type()` returning boxed value

    Previously handled by TypedField

    * Fix few incorrect translation keys

    * Remove resaving of comments when saving config files

    Comments ignoring is still a thing when reading, so `locked` configs for example will keep comments

    * Condense rule load messages in one

    * Only print loaded settings message when at least one setting was changed

    * Fix legacy validator detector

    * Tweak and add more context to response to invalid values

    * Fix strict validator not actually erroring on invalid input

commit f5a92eb
Author: gnembon <[email protected]>
Date:   Wed Jun 15 22:30:25 2022 +0200

    22w24a

commit 81d3b9e
Author: gnembon <[email protected]>
Date:   Tue Jun 7 17:41:02 2022 +0200

    curse

commit 5e5815c
Author: gnembon <[email protected]>
Date:   Tue Jun 7 17:37:35 2022 +0200

    1.19

commit 140cb15
Author: altrisi <[email protected]>
Date:   Wed Jun 1 22:37:39 2022 +0200

    Make newline in release message using zero-width character

    (​)

commit f0fbe32
Author: Dainternetdude <[email protected]>
Date:   Tue Apr 19 13:30:12 2022 -0600

    spelling

commit 486c2ec
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Jun 1 20:19:32 2022 +0000

    Merge docs for 'Carpet Mod 1.4.78 for 1.19-prerelease-5'

commit 7de976a
Author: Space Walker <[email protected]>
Date:   Wed Jun 1 04:39:22 2022 +0200

    fix gnembon#1454

commit 40af4f2
Author: gnembon <[email protected]>
Date:   Wed Jun 1 21:58:32 2022 +0200

    1.4.78 for 1.19-pre5

commit c10149b
Author: altrisi <[email protected]>
Date:   Sat May 28 13:07:08 2022 +0200

    Publish changelogs to Discord when releasing (gnembon#1428)

    Co-authored-by: Crec0 <[email protected]>

commit 8c7dfa1
Author: Luca Bertozzi <[email protected]>
Date:   Fri May 27 20:24:25 2022 +0200

    Added `__on_chunk_unloaded` scarpet event (gnembon#1451)

    * Fixes gnembon#1403

    * Use concrete type

commit d088ee4
Author: altrisi <[email protected]>
Date:   Fri May 27 19:44:39 2022 +0200

    Set mixin compatibility level to Java 17

commit f18cfb0
Author: altrisi <[email protected]>
Date:   Fri May 27 19:43:45 2022 +0200

    Fix more warnings and do some small optimizations (gnembon#1356)

    * Fix more warnings and do some small optimizations

    * Fix more warnings in ValueConversions

    * Clean up some decompiler names and fix an unnecessary transformation around commands

    * Use (way) more compact data structure for slot map

    * Minor tweaks
    Such as map directly in the collector

    * I hate vanilla javac
    Revert map changes in latest commit

commit e4dc080
Author: altrisi <[email protected]>
Date:   Tue May 24 15:26:31 2022 +0200

    Bump Loader requirement in `fabric.mod.json` too

commit fc54a87
Author: gnembon <[email protected]>
Date:   Mon May 23 23:07:33 2022 +0200

    1.4.77

commit 3a9e3b3
Author: gnembon <[email protected]>
Date:   Mon May 23 23:06:27 2022 +0200

    1.19-pre2

commit 08a6590
Author: altrisi <[email protected]>
Date:   Fri May 20 20:10:32 2022 +0200

    Remove `updateSuppressionCrashFix` and related logger (gnembon#1445)

commit b0a2f2c
Author: gnembon <[email protected]>
Date:   Wed May 18 21:10:15 2022 +0200

    1.4.76

commit 2af763d
Author: gnembon <[email protected]>
Date:   Wed May 18 21:08:32 2022 +0200

    1.19-pre1

commit bbe7701
Author: altrisi <[email protected]>
Date:   Tue May 17 22:06:49 2022 +0200

    Autogenerate refmap field in mixins json and remove empty `server` field

    Not explicitly specifying the refmap here also removes the log entry in dev environments where Mixin complains about missing refmap.

commit 668f309
Author: altrisi <[email protected]>
Date:   Tue May 17 21:55:22 2022 +0200

    Change missed usage of deprecated methods from gnembon#1383

commit 9daf72b
Author: Fx Morin <[email protected]>
Date:   Tue May 17 15:21:46 2022 -0400

    Update `updateSuppressionBlock` for 1.19 (gnembon#1401)

    * Changed Rule: `updateSuppressionBlock` to match new update suppression

    * Make it easier to use

    * Carpets mixin file will be the death of me

    * Renamed `WorldInterface` to `LevelInterface`
    Merged LevelAccessor with LevelInterface

    * Fix issues with 22w14a & resolve issues

    * Add `@Unique` to Level_tickMixin.java

    * Naming, brackets, and description

    * Return null on invalid

    * Fix remaining refactoring issues

commit a60bc38
Author: altrisi <[email protected]>
Date:   Tue May 17 20:11:49 2022 +0200

    Refactor `Module` into a single record type and fix system globals (gnembon#1383)

commit d681cb4
Author: gnembon <[email protected]>
Date:   Fri May 13 11:28:01 2022 +0200

    1.4.75

commit 1a6b1df
Author: gnembon <[email protected]>
Date:   Fri May 13 11:26:47 2022 +0200

    22w19a

commit 648ea01
Author: Ghoulboy <[email protected]>
Date:   Wed May 11 19:56:25 2022 +0200

    Making deepslate generate below y=0, not y=16 (gnembon#1433)

    * Fixes gnembon#1431

    * Updating carpet rule description

    * Making it work for cobbled deepslate

commit e5a3cdf
Author: gnembon <[email protected]>
Date:   Wed May 4 21:35:15 2022 +0200

    1.4.74

commit 217567c
Author: gnembon <[email protected]>
Date:   Wed May 4 21:34:22 2022 +0200

    22w18a

commit 544c1a8
Author: Crec0 <[email protected]>
Date:   Sun May 1 03:29:04 2022 -0700

    Profile categories splitting and descriptions. (gnembon#1375)

    * Split spawning and random ticks into separate categories

    * Split blocks into tile ticks and block events

    * Fix ambiguous call to tick() method
    Fix package private warning

    * fix: add missing sections for tile ticks and block events

    * fix: wrong profiling order

    * feat: add descriptions to profiler categories

    * refactor: replace guava ImmutableMap with jdk Map

    * fix negative time in "rest" category

commit 4662a86
Author: altrisi <[email protected]>
Date:   Fri Apr 29 20:16:03 2022 +0200

    Delete unused `BiomeArrayInterface`

commit c2c127b
Author: gnembon <[email protected]>
Date:   Wed Apr 27 20:17:56 2022 +0200

    1.4.73

commit fc8114b
Author: gnembon <[email protected]>
Date:   Wed Apr 27 20:16:56 2022 +0200

    added 'xpFromExplosions' for xp to always drop from exploding blocks

commit aaf8e7e
Author: gnembon <[email protected]>
Date:   Wed Apr 27 19:51:37 2022 +0200

    22w17a

commit 6111dec
Author: altrisi <[email protected]>
Date:   Thu Mar 17 21:21:44 2022 +0100

    Ease concrete restrictions on Annotated Scarpet API and make instantiating lazy

    Prevents instantiating classes with all annotated methods static, making it also more flexible in that you can put annotated functions near to other API that may be initialized

commit aafb740
Author: altrisi <[email protected]>
Date:   Sun Apr 24 13:30:55 2022 +0200

    Refactor BlockRotator (gnembon#1362)

    - Removes the unused accurate block placement protocol that has been dead there for ages
    - Removes the various rotate clockwise methods in favour of Direction's, that did exactly the same

    No behaviour changes

commit 8346199
Author: Crec0 <[email protected]>
Date:   Sun Apr 24 03:20:39 2022 -0700

    Fix "Unable to determine descriptor" warnings by setting `remap=false` at some locations. (gnembon#1423)

    * set remap=false for "Unable to determine descriptor" warnings

    * remove suppressWarning annotation

commit c1141dd
Author: altrisi <[email protected]>
Date:   Thu Apr 21 18:02:22 2022 +0200

    Fix latest commit about publishing, forgot a few blocks...

commit 91fbb44
Author: altrisi <[email protected]>
Date:   Thu Apr 21 18:00:22 2022 +0200

    Fix publishing warn, go back to loom 0.11 as 0.12 is not yet recommended

    See FabricMC/fabric-example-mod@8adede0

commit 127f4bb
Author: Fx Morin <[email protected]>
Date:   Thu Apr 21 02:17:47 2022 -0400

    Fix carpet not building by updating loom (gnembon#1422)

    * Attempt to fix github issue

commit d03900a
Author: gnembon <[email protected]>
Date:   Thu Apr 21 00:30:35 2022 +0200

    1.4.72

commit 746c854
Author: gnembon <[email protected]>
Date:   Thu Apr 21 00:26:39 2022 +0200

    22w16b with massive Component changes

commit 8101abb
Author: gnembon <[email protected]>
Date:   Wed Apr 20 23:19:59 2022 +0200

    retire extreme behaviours, added moreBlueSkulls

commit b2cb70c
Author: altrisi <[email protected]>
Date:   Wed Apr 20 14:57:50 2022 +0200

    Remove cotton maven given lQF is now on the Gradle plugin portal (gnembon#1420)

    * Bump QuilfFlower version

    * Remove cotton maven given loom QuiltFlower is now in the Gradle plugin portal

commit 8c2ded4
Author: altrisi <[email protected]>
Date:   Wed Apr 20 13:50:44 2022 +0200

    Simplify mod initializers and prevent extensions from mixing into Carpet just to register themselves (gnembon#1396)

commit 83b0fb1
Author: altrisi <[email protected]>
Date:   Wed Apr 20 13:29:31 2022 +0200

    Show local type in exception hover tooltips (gnembon#1397)

commit 80a5342
Author: altrisi <[email protected]>
Date:   Wed Apr 20 13:27:25 2022 +0200

    Make scarpet internal and control flow exceptions stackless (gnembon#1392)

commit 7686147
Author: altrisi <[email protected]>
Date:   Wed Apr 20 13:01:58 2022 +0200

    Add support for formatted names in `create_marker` (gnembon#1413)

commit b6fa657
Author: altrisi <[email protected]>
Date:   Fri Apr 15 19:39:07 2022 +0200

    Highlight scarpet files with github's highlighter for python (gnembon#1407)

commit 0234605
Author: gnembon <[email protected]>
Date:   Wed Apr 13 21:11:21 2022 +0200

    1.4.71

commit e5af397
Author: gnembon <[email protected]>
Date:   Wed Apr 13 21:10:24 2022 +0200

    22w15a

commit f590e9d
Author: altrisi <[email protected]>
Date:   Mon Apr 11 12:59:51 2022 +0200

    Fix latest commit

commit 96bb107
Author: altrisi <[email protected]>
Date:   Mon Apr 11 12:51:55 2022 +0200

    Remove chest boat from living entities

    Fixes gnembon#1405.

commit 3780d5f
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Apr 6 20:30:20 2022 +0000

    Merge docs for 'Carpet Mod 1.4.70 for 22w14a (1.19 snapshot)'

commit a1a41f9
Author: gnembon <[email protected]>
Date:   Wed Apr 6 22:16:47 2022 +0200

    1.4.70

commit 812d361
Author: gnembon <[email protected]>
Date:   Wed Apr 6 22:16:05 2022 +0200

    22w14a

commit fca98c7
Author: BisUmTo <[email protected]>
Date:   Mon Apr 4 12:34:48 2022 +0200

    Fixed execution offset in screens callback context (gnembon#1353)

    Wrong origin in screen callbacks

commit 6ebef9b
Author: altrisi <[email protected]>
Date:   Mon Apr 4 10:28:08 2022 +0200

    Simplify cache in action workflows (gnembon#1359)

    * Simplify `build-on-pr` workflow

    * Simplify `devbuild` workflow

    * Simplify `publish-release` action

commit 9a804d5
Author: rv3r <[email protected]>
Date:   Mon Apr 4 04:26:06 2022 -0400

    Docs edit, noted double backslash requirement for some regex operators (gnembon#1361)

commit 5e9b391
Author: Fx Morin <[email protected]>
Date:   Sun Apr 3 07:17:33 2022 -0400

    Sculk sensor range (gnembon#1389)

    * New Rule: `sculkSensorRange`

commit 330fd6f
Author: altrisi <[email protected]>
Date:   Sun Apr 3 13:06:29 2022 +0200

    Make `desertShrubs` check for waterlogged blocks instead of just water blocks (gnembon#1388)

commit 4db1c95
Merge: ea9ea3f d27767b
Author: gnembon <[email protected]>
Date:   Fri Apr 1 01:32:58 2022 +0200

    Merge branch 'master' into future

commit d27767b
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Thu Mar 31 21:26:05 2022 +0000

    Merge docs for 'Carpet Mod 1.4.69 for Minecraft 1.18.2 and 22w13a'

commit ea9ea3f
Merge: ef3e71b bee280f
Author: gnembon <[email protected]>
Date:   Thu Mar 31 23:11:36 2022 +0200

    Merge branch 'master' into future

    # Conflicts:
    #	gradle.properties

commit bee280f
Author: gnembon <[email protected]>
Date:   Thu Mar 31 23:06:35 2022 +0200

    1.4.69

commit 72fe6ee
Author: gnembon <[email protected]>
Date:   Thu Mar 31 22:36:52 2022 +0200

    curse

commit ef3e71b
Author: gnembon <[email protected]>
Date:   Thu Mar 31 20:23:49 2022 +0200

    22w13a

commit 79f994f
Author: gnembon <[email protected]>
Date:   Wed Mar 30 07:52:44 2022 +0200

    enable_hidden_dimensions is ded :(

commit 842370f
Merge: 2b72016 c33c53c
Author: gnembon <[email protected]>
Date:   Wed Mar 30 07:49:07 2022 +0200

    Merge branch 'master' into future

    # Conflicts:
    #	src/main/java/carpet/script/api/Auxiliary.java

commit c33c53c
Author: gnembon <[email protected]>
Date:   Wed Mar 30 07:44:37 2022 +0200

    enable_hidden_dimensions is ded :(

commit 2b72016
Merge: ab07a68 6d10f36
Author: gnembon <[email protected]>
Date:   Thu Mar 24 21:54:28 2022 +0100

    Merge branch 'master' into future

commit 6d10f36
Author: gnembon <[email protected]>
Date:   Thu Mar 24 21:53:58 2022 +0100

    1.4.68

commit ab07a68
Author: gnembon <[email protected]>
Date:   Thu Mar 24 21:48:29 2022 +0100

    22w12a

commit 2743908
Author: gnembon <[email protected]>
Date:   Thu Mar 24 21:20:19 2022 +0100

    use proper registires, still issues.

commit 7c353d4
Merge: d9c227f d1f3886
Author: gnembon <[email protected]>
Date:   Thu Mar 24 21:18:53 2022 +0100

    Merge branch 'master' into future

commit d1f3886
Author: gnembon <[email protected]>
Date:   Thu Mar 24 21:18:32 2022 +0100

    use proper registires, still issues.

commit d9c227f
Author: gnembon <[email protected]>
Date:   Wed Mar 23 18:31:06 2022 +0100

    mappings

commit cd1854a
Merge: 679045b aab3de6
Author: gnembon <[email protected]>
Date:   Wed Mar 23 18:21:45 2022 +0100

    Merge branch 'master' into future

commit aab3de6
Author: gnembon <[email protected]>
Date:   Wed Mar 23 18:21:15 2022 +0100

    add reload resources after reload, still not fixing the issues

commit 679045b
Merge: f4bccfb f213a79
Author: gnembon <[email protected]>
Date:   Mon Mar 21 21:19:35 2022 +0100

    Merge branch 'master' into future

    # Conflicts:
    #	src/main/java/carpet/script/api/Auxiliary.java

commit f213a79
Author: gnembon <[email protected]>
Date:   Mon Mar 21 21:14:20 2022 +0100

    adapt to 1.18.2 for enable dimensions fix

commit c4ab246
Author: gnembon <[email protected]>
Date:   Sun Mar 20 15:16:31 2022 +0100

    fixes biomes not saving fixes gnembon#1322

commit f4bccfb
Author: gnembon <[email protected]>
Date:   Fri Mar 18 16:45:47 2022 +0100

    fix

commit 7003ea8
Merge: 0773a7d 6ed33ec
Author: gnembon <[email protected]>
Date:   Fri Mar 18 16:42:44 2022 +0100

    Merge branch 'master' into future

    # Conflicts:
    #	src/main/java/carpet/helpers/FeatureGenerator.java

commit 6ed33ec
Author: gnembon <[email protected]>
Date:   Fri Mar 18 16:41:21 2022 +0100

    structures save to world, fixes gnembon#1346, attempt to fix biome and dimension recreation, but the other ones need more testing.

commit 0773a7d
Merge: 193cf37 814147d
Author: gnembon <[email protected]>
Date:   Fri Mar 18 00:26:12 2022 +0100

    Merge branch 'master' into future

commit 814147d
Author: gnembon <[email protected]>
Date:   Fri Mar 18 00:21:48 2022 +0100

    1.4.67

commit 193cf37
Author: gnembon <[email protected]>
Date:   Thu Mar 17 23:57:42 2022 +0100

    fixes for 22w11a

commit 302a7b4
Author: gnembon <[email protected]>
Date:   Thu Mar 17 20:21:55 2022 +0100

    fixes for 22w11a

commit 3e419d1
Author: gnembon <[email protected]>
Date:   Mon Mar 7 23:06:35 2022 +0100

    assuming fixes gnembon#1354

commit e9656a2
Author: gnembon <[email protected]>
Date:   Mon Mar 7 22:26:03 2022 +0100

    fix unclosed chests, fixes gnembon#1352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scarpet Issues related to scarpet in some way
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Module into a single record type and fix system globals altrisi/fabric-carpet
1 participant
@altrisi