Remove useless braces. (#814)

gnikyt · Jun 21, 2021 · 3438c96 · 3438c96
1 parent 11cd366
commit 3438c96
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/src/ShopifyApp/Http/Middleware/AuthToken.php b/src/ShopifyApp/Http/Middleware/AuthToken.php
@@ -80,7 +80,7 @@ public function handle(Request $request, Closure $next)
             throw new HttpException('Malformed token', 400);
         }
 
-        if (($now > $body->exp) || ($now < $body->nbf) || ($now < $body->iat)) {
+        if ($now > $body->exp || $now < $body->nbf || $now < $body->iat) {
             throw new HttpException('Expired token', 403);
         }
 

diff --git a/src/ShopifyApp/Services/CookieHelper.php b/src/ShopifyApp/Services/CookieHelper.php
@@ -75,8 +75,7 @@ public function checkSameSiteNoneCompatible(): bool
             $compatible = true;
         }
 
-        if ($this->agent->is('OS X') &&
-            ($this->agent->is('Safari') && ! $this->agent->is('iOS')) &&
+        if ($this->agent->is('OS X') && $this->agent->is('Safari') && ! $this->agent->is('iOS') &&
             $platform['float'] > 10.14
         ) {
             $compatible = true;

diff --git a/src/ShopifyApp/Traits/ShopModel.php b/src/ShopifyApp/Traits/ShopModel.php
@@ -98,15 +98,15 @@ public function plan(): BelongsTo
      */
     public function isGrandfathered(): bool
     {
-        return ((bool) $this->shopify_grandfathered) === true;
+        return (bool) $this->shopify_grandfathered === true;
     }
 
     /**
      * {@inheritdoc}
      */
     public function isFreemium(): bool
     {
-        return ((bool) $this->shopify_freemium) === true;
+        return (bool) $this->shopify_freemium === true;
     }
 
     /**

diff --git a/src/ShopifyApp/helpers.php b/src/ShopifyApp/helpers.php
@@ -32,7 +32,7 @@ function createHmac(array $opts, string $secret): string
             $queryCompiled[] = "{$key}=".(is_array($value) ? implode(',', $value) : $value);
         }
         $data = implode(
-            ($buildQueryWithJoin ? '&' : ''),
+            $buildQueryWithJoin ? '&' : '',
             $queryCompiled
         );
     }
@@ -62,7 +62,10 @@ function parseQueryString(string $qs, string $d = null): array
     $DEFAULT_SEP = '/[&;]\s*/';
 
     $params = [];
-    $split = preg_split($d ? ($COMMON_SEP[$d] || '/['.$d.']\s*/') : $DEFAULT_SEP, $qs ?? '');
+    $split = preg_split(
+        $d ? $COMMON_SEP[$d] || '/['.$d.']\s*/' : $DEFAULT_SEP,
+        $qs ?? ''
+    );
 
     foreach ($split as $p) {
         if (! $p) {