Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Non-embedded app issue #16

Closed
pasartap opened this issue Mar 9, 2018 · 5 comments
Closed

Non-embedded app issue #16

pasartap opened this issue Mar 9, 2018 · 5 comments
Assignees
Labels
feature Enhancement to the code

Comments

@pasartap
Copy link

pasartap commented Mar 9, 2018

Hi there, is it possible to make the app not embedded in the Shopify admin? I tried disabling the Embed in Shopify admin setting but when I load the app the following occurs:

  1. A new window is opened.
  2. The index page loads for less than a second.
  3. Some redirect happens and now the Shopify 404 page is shown.

Below is the URI generated:
https://pasartap-dev.myshopify.com/admin/apps/e1ef58708fea1eee57e4b47ba6635a05/?hmac=b79e691545e56d13d4273f50f4a20cee2bb8ff414314fae465292a95d0058fc1&shop=pasartap-dev.myshopify.com&timestamp=1520584470

Appreciate any help, thanks.

Razaly

@gnikyt
Copy link
Owner

gnikyt commented Mar 10, 2018

Hey

This package doesn't have support for the legacy method. I'll have to see what I can do to add the support in, shouldn't be much. I think essentially because the ESDK JS is in the layout file it's attempting to redirect and load your app into the iframe.

I'll check it out this week and see what I can do to add the support.

@gnikyt
Copy link
Owner

gnikyt commented Mar 11, 2018

@pasartap v2.1.0 should fix your issue. Update to 2.1.0 then added SHOPIFY_ESDK_ENABLED=0 to your environment and it should work as expected.

@gnikyt gnikyt added the feature Enhancement to the code label Mar 11, 2018
@gnikyt gnikyt self-assigned this Mar 11, 2018
@gnikyt
Copy link
Owner

gnikyt commented Mar 14, 2018

I believe this issue should be fine now. I'll close for now. If it is not, feel free to open but in my tests (code and physical) this new addition works as expected :)

@pasartap
Copy link
Author

Thanks!

@manpreet396
Copy link

Hi Tyler,
(#16 (comment))
This is not working in latest version, Can you please help me to solve this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Enhancement to the code
Projects
None yet
Development

No branches or pull requests

3 participants