Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Feature | Add Session Refresh Time to ENV #1117

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

Kyon147
Copy link
Collaborator

@Kyon147 Kyon147 commented Apr 13, 2022

This PR adds the refresh token interval found in token.blade to the config so that the default time of 2 seconds can be changed by the user.

This helps #1116 and #1076

@Kyon147 Kyon147 requested a review from gnikyt April 13, 2022 08:03
@Kyon147 Kyon147 added the feature Enhancement to the code label Apr 13, 2022
@Kyon147
Copy link
Collaborator Author

Kyon147 commented Apr 27, 2022

@lucasmichot @osiset - can you review this for me. We can then do a minor/major release for Laravel 9 support and add this in as well if it is good.

Copy link
Owner

@gnikyt gnikyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You may not need the ?? in the blade file, as env has the default value defined? But yeah, not a worry, good to merge I think.

Copy link
Collaborator

@lucasmichot lucasmichot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change required

src/resources/views/partials/token_handler.blade.php Outdated Show resolved Hide resolved
@Kyon147
Copy link
Collaborator Author

Kyon147 commented Apr 27, 2022

@osiset @lucasmichot - removed that 👍

Copy link
Owner

@gnikyt gnikyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kyon147 Good to merge.

@Kyon147 Kyon147 merged commit 1d5b351 into master Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Enhancement to the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants