This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Propose to fix Billable app throwing exception on install #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PHP 8.0: Deprecate required parameters after optional parameters in function/method signatures
|
@osiset going to merge this one (later) in too for the upcoming release as php8.1 is being used more and more and this fix stops the billing route breaking as the optional param needs to be at the end of the method. |
Kyon147
approved these changes
Aug 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHP 8.0: Deprecate required parameters after optional parameters in function/method signatures