This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a route prefix,
Str::startsWith($request->getRequestUri(), ['/authenticate', '/billing'])
isn't going to match the route URL. I changed it toStr::contains()
so that it can be anywhere in the URL.Case in point - my routes:
This can still potentially cause problems if the "authenticate" or "billing" routes are manually registered and don't contain
/authenticate
or/billing
. However, IMO that's a pretty big edge case that I don't think needs to be accounted for at this point.