Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Replace all the helpers by a Util class #844

Merged
merged 6 commits into from
Jun 24, 2021
Merged

Replace all the helpers by a Util class #844

merged 6 commits into from
Jun 24, 2021

Conversation

lucasmichot
Copy link
Collaborator

Replace all the helpers by a Util class

@lucasmichot lucasmichot mentioned this pull request Jun 23, 2021
@lucasmichot lucasmichot requested a review from gnikyt June 24, 2021 08:24
@gnikyt
Copy link
Owner

gnikyt commented Jun 24, 2021

Hope this merges well with feature/cookieless, thanks a lot!

@gnikyt gnikyt merged commit e195d81 into master Jun 24, 2021
@gnikyt gnikyt deleted the helper-class branch June 24, 2021 12:44
@gnikyt
Copy link
Owner

gnikyt commented Jun 24, 2021

As an update... nice few conflicts but resolved them easily on the cookieless branch. Thanks!

@lucasmichot
Copy link
Collaborator Author

I was just looking at your branch 👍

Why not opening a draft PR for this one ?

@gnikyt
Copy link
Owner

gnikyt commented Jun 24, 2021

Thats what I have scheduled to do this afternoon :), no red flags with the cookieless branch finally, I think its in a state to begin pushing it to master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants