renames, remove error

gno.land/cmd/gnoland/testdata/maketx_call_pure.txtar

@@ -0,0 +1,32 @@
+# load the package
+loadpkg gno.land/p/foo/call_package $WORK/package
+loadpkg gno.land/r/foo/call_realm $WORK/realm
+
+# start a new node
+gnoland start
+
+# 1. call to package ERROR
+! gnokey maketx call -pkgpath gno.land/p/foo/call_package -func Render -gas-fee 1000000ugnot -gas-wanted 2000000 -broadcast -chainid=tendermint_test test1
+stderr '"gnokey" error: --= Error =--\nData: invalid package path'
+
+# 2. call to stdlibs ERROR
+! gnokey maketx call -pkgpath strconv -func Itoa -args 11 -gas-fee 1000000ugnot -gas-wanted 2000000 -broadcast -chainid=tendermint_test test1
+stderr '"gnokey" error: --= Error =--\nData: invalid package path'
+
+# 3. normal call to realm PASS
+gnokey maketx call -pkgpath gno.land/r/foo/call_realm -func Render -gas-fee 1000000ugnot -gas-wanted 2000000 -broadcast -chainid=tendermint_test test1
+stdout OK!
+
+-- package/package.gno --
+package call_package
+
+func Render() string {
+ 	return "notok"
+}
+
+-- realm/realm.gno --
+package call_realm
+
+func Render() string {
+ 	return "ok"
+}

gno.land/pkg/sdk/vm/errors.go

@@ -22,7 +22,6 @@ type (
 		abciError
 		Errors []string
 	}
-	ForbiddenPkgCallError struct{ abciError }
 )
 
 func (e InvalidPkgPathError) Error() string { return "invalid package path" }
@@ -34,7 +33,6 @@ func (e TypeCheckError) Error() string {
 	bld.WriteString(strings.Join(e.Errors, "\n"))
 	return bld.String()
 }
-func (e ForbiddenPkgCallError) Error() string { return "forbidden/bad package called" }
 
 func ErrInvalidPkgPath(msg string) error {
 	return errors.Wrap(InvalidPkgPathError{}, msg)
@@ -56,7 +54,3 @@ func ErrTypeCheck(err error) error {
 	}
 	return errors.NewWithData(tce).Stacktrace()
 }
-
-func ErrForbiddenPkgCall(msg string) error {
-	return errors.Wrap(ForbiddenPkgCallError{}, msg)
-}

gno.land/pkg/sdk/vm/msgs.go

@@ -113,11 +113,11 @@ func (msg MsgCall) ValidateBasic() error {
 	if msg.Caller.IsZero() {
 		return std.ErrInvalidAddress("missing caller address")
 	}
-	if msg.PkgPath == "" { // XXX
+	if msg.PkgPath == "" {
 		return ErrInvalidPkgPath("missing package path")
 	}
 	if !gno.IsRealmPath(msg.PkgPath) {
-		return ErrForbiddenPkgCall("pkgpath must be a realm")
+		return ErrInvalidPkgPath("pkgpath must be of a realm")
 	}
 	if msg.Func == "" { // XXX
 		return ErrInvalidExpr("missing function to call")

gno.land/pkg/sdk/vm/package.go

@@ -21,5 +21,4 @@ var Package = amino.RegisterPackage(amino.NewPackage(
 	InvalidStmtError{}, "InvalidStmtError",
 	InvalidExprError{}, "InvalidExprError",
 	TypeCheckError{}, "TypeCheckError",
-	ForbiddenPkgCallError{}, "ForbiddenPkgCallError",
 ))

gnovm/pkg/gnolang/realm.go

@@ -1518,7 +1518,7 @@ func isUnsaved(oo Object) bool {
 // be realms and as such to have their state persisted. This is used by [IsRealmPath].
 const realmPathPrefix = "gno.land/r/"
 
-var ReGnoRunPath = regexp.MustCompile(`gno\.land/r/g[a-z0-9]+/run`)
+var ReGnoRunPath = regexp.MustCompile(`^gno\.land/r/g[a-z0-9]+/run$`)
 
 // IsRealmPath determines whether the given pkgpath is for a realm, and as such
 // should persist the global state.