Skip to content

Commit

Permalink
chore(ci): do not mark master as failing due to benchmark (#2913)
Browse files Browse the repository at this point in the history
  • Loading branch information
@moul
moul authored Oct 5, 2024
1 parent d3049ae commit 628f965
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/benchmark-master-push.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
max-items-in-chart: 100
# Show alert with commit comment on detecting possible performance regression
alert-threshold: "120%"
fail-on-alert: true
fail-on-alert: false
comment-on-alert: true
alert-comment-cc-users: "@ajnavarro,@thehowl,@zivkovicmilos"
# Enable Job Summary for PRs
Expand Down

1 comment on commit 628f965

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Go Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 628f965 Previous: 8a62a28 Ratio
BenchmarkPreprocessForLoop 1827091 ns/op 5829 B/op 44 allocs/op 1450272 ns/op 5798 B/op 44 allocs/op 1.26
BenchmarkPreprocessForLoop - ns/op 1827091 ns/op 1450272 ns/op 1.26
BenchmarkPreprocessForLoop 1814648 ns/op 5952 B/op 44 allocs/op 1450272 ns/op 5798 B/op 44 allocs/op 1.25
BenchmarkPreprocessForLoop - ns/op 1814648 ns/op 1450272 ns/op 1.25
BenchmarkBenchdata/loop.gno 179.6 ns/op 0 B/op 0 allocs/op 139 ns/op 0 B/op 0 allocs/op 1.29
BenchmarkBenchdata/loop.gno - ns/op 179.6 ns/op 139 ns/op 1.29
BenchmarkBenchdata/loop.gno 178.8 ns/op 0 B/op 0 allocs/op 139 ns/op 0 B/op 0 allocs/op 1.29
BenchmarkBenchdata/loop.gno - ns/op 178.8 ns/op 139 ns/op 1.29
BenchmarkBinary/EmptyStruct:encode 719.6 ns/op 96 B/op 2 allocs/op 535.8 ns/op 96 B/op 2 allocs/op 1.34
BenchmarkBinary/EmptyStruct:encode - ns/op 719.6 ns/op 535.8 ns/op 1.34
BenchmarkBinary/EmptyStruct:decode 430.8 ns/op 0 B/op 0 allocs/op 263.7 ns/op 0 B/op 0 allocs/op 1.63
BenchmarkBinary/EmptyStruct:decode - ns/op 430.8 ns/op 263.7 ns/op 1.63
BenchmarkBinary/ShortArraysStruct:encode 1272 ns/op 192 B/op 4 allocs/op 1040 ns/op 192 B/op 4 allocs/op 1.22
BenchmarkBinary/ShortArraysStruct:encode - ns/op 1272 ns/op 1040 ns/op 1.22
BenchmarkBinary/ShortArraysStruct:decode 616.4 ns/op 0 B/op 0 allocs/op 376.1 ns/op 0 B/op 0 allocs/op 1.64
BenchmarkBinary/ShortArraysStruct:decode - ns/op 616.4 ns/op 376.1 ns/op 1.64
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 63326780 ns/op 5130 B/op 9 allocs/op 36014566 ns/op 5126 B/op 9 allocs/op 1.76
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 63326780 ns/op 36014566 ns/op 1.76
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 126630173 ns/op 5139 B/op 9 allocs/op 36014566 ns/op 5126 B/op 9 allocs/op 3.52
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 126630173 ns/op 36014566 ns/op 3.52
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 253270009 ns/op 5158 B/op 9 allocs/op 36014566 ns/op 5126 B/op 9 allocs/op 7.03
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 253270009 ns/op 36014566 ns/op 7.03
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 505726068 ns/op 5196 B/op 10 allocs/op 36014566 ns/op 5126 B/op 9 allocs/op 14.04
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 505726068 ns/op 36014566 ns/op 14.04
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 1012483618 ns/op 5736 B/op 15 allocs/op 36014566 ns/op 5126 B/op 9 allocs/op 28.11
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 1012483618 ns/op 36014566 ns/op 28.11
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - allocs/op 15 allocs/op 9 allocs/op 1.67
BenchmarkBcryptGenerateFromPassword/benchmark-security-param 2023655745 ns/op 5736 B/op 15 allocs/op 36014566 ns/op 5126 B/op 9 allocs/op 56.19
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - ns/op 2023655745 ns/op 36014566 ns/op 56.19
BenchmarkBcryptGenerateFromPassword/benchmark-security-param - allocs/op 15 allocs/op 9 allocs/op 1.67
BenchmarkSigning 87572 ns/op 1856 B/op 36 allocs/op 33593 ns/op 64 B/op 1 allocs/op 2.61
BenchmarkSigning - ns/op 87572 ns/op 33593 ns/op 2.61
BenchmarkSigning - B/op 1856 B/op 64 B/op 29
BenchmarkSigning - allocs/op 36 allocs/op 1 allocs/op 36
BenchmarkSigning 89184 ns/op 1856 B/op 36 allocs/op 33593 ns/op 64 B/op 1 allocs/op 2.65
BenchmarkSigning - ns/op 89184 ns/op 33593 ns/op 2.65
BenchmarkSigning - B/op 1856 B/op 64 B/op 29
BenchmarkSigning - allocs/op 36 allocs/op 1 allocs/op 36
BenchmarkVerification 172688 ns/op 864 B/op 19 allocs/op 109978 ns/op 0 B/op 0 allocs/op 1.57
BenchmarkVerification - ns/op 172688 ns/op 109978 ns/op 1.57
BenchmarkVerification - B/op 864 B/op 0 B/op +∞
BenchmarkVerification - allocs/op 19 allocs/op 0 allocs/op +∞
BenchmarkVerification 169126 ns/op 864 B/op 19 allocs/op 109978 ns/op 0 B/op 0 allocs/op 1.54
BenchmarkVerification - ns/op 169126 ns/op 109978 ns/op 1.54
BenchmarkVerification - B/op 864 B/op 0 B/op +∞
BenchmarkVerification - allocs/op 19 allocs/op 0 allocs/op +∞
BenchmarkGoLevelDBRandomReadsWrites - B/op 579 B/op 453 B/op 1.28
BenchmarkGoLevelDBRandomReadsWrites - B/op 617 B/op 453 B/op 1.36
BenchmarkRandomBytes/random 82.67 ns/op 16 B/op 1 allocs/op 49.57 ns/op 4 B/op 1 allocs/op 1.67
BenchmarkRandomBytes/random - ns/op 82.67 ns/op 49.57 ns/op 1.67
BenchmarkRandomBytes/random - B/op 16 B/op 4 B/op 4
BenchmarkRandomBytes/random 121.8 ns/op 32 B/op 1 allocs/op 49.57 ns/op 4 B/op 1 allocs/op 2.46
BenchmarkRandomBytes/random - ns/op 121.8 ns/op 49.57 ns/op 2.46
BenchmarkRandomBytes/random - B/op 32 B/op 4 B/op 8
BenchmarkRandomBytes/random 301.6 ns/op 112 B/op 1 allocs/op 49.57 ns/op 4 B/op 1 allocs/op 6.08
BenchmarkRandomBytes/random - ns/op 301.6 ns/op 49.57 ns/op 6.08
BenchmarkRandomBytes/random - B/op 112 B/op 4 B/op 28
BenchmarkRandomBytes/random 2621 ns/op 1024 B/op 1 allocs/op 49.57 ns/op 4 B/op 1 allocs/op 52.87
BenchmarkRandomBytes/random - ns/op 2621 ns/op 49.57 ns/op 52.87
BenchmarkRandomBytes/random - B/op 1024 B/op 4 B/op 256
BenchmarkSmall/boltdb-1000-100-16-40/update 889169 ns/op 36660 B/op 366 allocs/op 701930 ns/op 36092 B/op 352 allocs/op 1.27
BenchmarkSmall/boltdb-1000-100-16-40/update - ns/op 889169 ns/op 701930 ns/op 1.27
BenchmarkSmall/boltdb-1000-100-16-40/update 1393804 ns/op 45140 B/op 388 allocs/op 701930 ns/op 36092 B/op 352 allocs/op 1.99
BenchmarkSmall/boltdb-1000-100-16-40/update - ns/op 1393804 ns/op 701930 ns/op 1.99
BenchmarkSmall/boltdb-1000-100-16-40/update - B/op 45140 B/op 36092 B/op 1.25
BenchmarkSmall/goleveldb-1000-100-16-40/block - B/op 4421810 B/op 3216037 B/op 1.37
BenchmarkSmall/goleveldb-1000-100-16-40/block - allocs/op 47115 allocs/op 35463 allocs/op 1.33
BenchmarkSmall/memdb-1000-100-16-40/block - B/op 8952625 B/op 6361108 B/op 1.41
BenchmarkSmall/memdb-1000-100-16-40/block - allocs/op 162751 allocs/op 111944 allocs/op 1.45
BenchmarkMedium/boltdb-100000-100-16-40/update 6257111 ns/op 127324 B/op 987 allocs/op 3521979 ns/op 85641 B/op 726 allocs/op 1.78
BenchmarkMedium/boltdb-100000-100-16-40/update - ns/op 6257111 ns/op 3521979 ns/op 1.78
BenchmarkMedium/boltdb-100000-100-16-40/update - B/op 127324 B/op 85641 B/op 1.49
BenchmarkMedium/boltdb-100000-100-16-40/update - allocs/op 987 allocs/op 726 allocs/op 1.36
BenchmarkMedium/memdb-100000-100-16-40/update - B/op 263021 B/op 152744 B/op 1.72
BenchmarkMedium/memdb-100000-100-16-40/update - allocs/op 5080 allocs/op 2791 allocs/op 1.82
BenchmarkMedium/memdb-100000-100-16-40/update 1171611 ns/op 388834 B/op 7708 allocs/op 898787 ns/op 152744 B/op 2791 allocs/op 1.30
BenchmarkMedium/memdb-100000-100-16-40/update - ns/op 1171611 ns/op 898787 ns/op 1.30
BenchmarkMedium/memdb-100000-100-16-40/update - B/op 388834 B/op 152744 B/op 2.55
BenchmarkMedium/memdb-100000-100-16-40/update - allocs/op 7708 allocs/op 2791 allocs/op 2.76
BenchmarkLevelDBBatchSizes/goleveldb-100000-400-16-40/update - B/op 49453 B/op 39069 B/op 1.27
BenchmarkLevelDBBatchSizes/goleveldb-100000-400-16-40/update - allocs/op 597 allocs/op 453 allocs/op 1.32
BenchmarkLevelDBBatchSizes/goleveldb-100000-2000-16-40/update - allocs/op 424 allocs/op 340 allocs/op 1.25
BenchmarkHash/ripemd160 3614 ns/op 25 B/op 1 allocs/op 1081 ns/op 25 B/op 1 allocs/op 3.34
BenchmarkHash/ripemd160 - ns/op 3614 ns/op 1081 ns/op 3.34
BenchmarkHash/sha2-256 1626 ns/op 33 B/op 1 allocs/op 570.9 ns/op 33 B/op 1 allocs/op 2.85
BenchmarkHash/sha2-256 - ns/op 1626 ns/op 570.9 ns/op 2.85
BenchmarkHash/sha3-256 1953 ns/op 33 B/op 1 allocs/op 1074 ns/op 33 B/op 1 allocs/op 1.82
BenchmarkHash/sha3-256 - ns/op 1953 ns/op 1074 ns/op 1.82

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ajnavarro @thehowl @zivkovicmilos

Please sign in to comment.