[chain] Upload and display benchmarks for the gno monorepo #2432
Assignees
Milestone
Comments
|
Where are benchmarks results supposed to be published at? Was this URL working:https://gnolang.github.io/benchmarks/ |
|
I think it's working now, just showing 404 because there is no benchmark data |
|
We can host it anywhere you think it makes sense |
|
Nice. But I have seen that benchmark related workflows are actually disabled / or not working. |
|
I have no hint where the dedicated Runner is at, I expected everything running in Github, but maybe these tasks are too heavy to run within Github's runners. |
sw360cab
added a commit
that referenced
this issue
Sep 26, 2024
## Things changes * using new action plugin: [benchmark-action/github-action-benchmark](https://github.com/benchmark-action/github-action-benchmark) * previous library was [bobheadxi/gobenchdata](https://github.com/bobheadxi/gobenchdata) * creating alerts when benchmarks results are worse ## Things unchanged * Pushing benchmarks results onto a local branch, then `benchmark` repository will fetch from this into his own `gh-pages` * direct push is possible but requires PAT token to be used ## Things TODO (before merging) * restore benchmarks actions which were manually disabled directly in the `Action` menu in Github * drop and recreate branch `gh-repository` * fix benchmark tests in Gno repo (see #2711 and #2714) * Evaluate alternative configuration possibilities [here](https://github.com/benchmark-action/github-action-benchmark?tab=readme-ov-file#action-inputs) ## Things to consider (performance) * Should solve #2432 * are resources available in the Github basic runners enough for benchmarks? * are multiple runs spawned in the same hw conditions? * consider using [Larger Runner](https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners/managing-larger-runners#adding-a-larger-runner-to-an-organization) or restoring a [Self-Hosted Runner](https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/adding-self-hosted-runners#adding-a-self-hosted-runner-to-an-organization)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
This task concerns better utilizing the benchmarking workflows added in by @ajnavarro:
https://github.com/gnolang/gno/tree/master/.benchmarks
Currently, the workflows for the benchmarks require a dedicated machine (runner) to trigger and upload benchmark data on GH pages.
Definition of done:
The text was updated successfully, but these errors were encountered: