feat: add p/demo/pausable #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1328 +/- ##
==========================================
+ Coverage 47.89% 56.37% +8.48%
==========================================
Files 372 421 +49
Lines 63019 67691 +4672
==========================================
+ Hits 30180 38163 +7983
+ Misses 30373 26592 -3781
- Partials 2466 2936 +470 ☔ View full report in Codecov by Sentry. |
deelawn
approved these changes
Nov 6, 2023
deelawn
reviewed
Nov 6, 2023
thehowl
approved these changes
Nov 9, 2023
3 tasks
zivkovicmilos
approved these changes
Nov 9, 2023
moul
approved these changes
Nov 9, 2023
moul
pushed a commit
to moul/gno
that referenced
this pull request
Nov 14, 2023
## Description This PR adds the `Pausable` package to p/demo, allowing realms to have pausability. It relies on the already existing `Ownable` package for access control, gnolang#1314. Inspired by OpenZeppelin's [Pausable](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v4.9.3/contracts/security/Pausable.sol). <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Morgan Bazalgette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
Pausablepackage to p/demo, allowing realms to have pausability. It relies on the already existingOwnablepackage for access control, #1314.Inspired by OpenZeppelin's Pausable.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description