Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk/vm): coerce MsgRun pkgpath to gno.land/r/$addr/run #1645

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Feb 8, 2024

This is the path that is reserved, but right now the handler for MsgRun allows any path to be used. This PR enforces all run calls to happen here exclusively.

@thehowl thehowl self-assigned this Feb 8, 2024
@thehowl thehowl requested a review from moul as a code owner February 8, 2024 15:59
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f060eb3) 56.51% compared to head (f5d502a) 56.52%.
Report is 3 commits behind head on master.

Files Patch % Lines
gno.land/pkg/sdk/vm/msgs.go 25.00% 3 Missing ⚠️
gno.land/pkg/gnoclient/client_txs.go 0.00% 1 Missing ⚠️
gno.land/pkg/sdk/vm/keeper.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1645   +/-   ##
=======================================
  Coverage   56.51%   56.52%           
=======================================
  Files         439      439           
  Lines       66561    66567    +6     
=======================================
+ Hits        37619    37625    +6     
+ Misses      26021    26020    -1     
- Partials     2921     2922    +1     
Flag Coverage Δ
go-1.21.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl merged commit 59d8787 into master Feb 9, 2024
180 checks passed
@thehowl thehowl deleted the dev/morgan/run-only-in-path branch February 9, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants