Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gnovm): rename precompiler to transpiler, move to own package #1681

Merged
merged 9 commits into from
Feb 28, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Feb 22, 2024

Part 1 of several transpiler refactors I intend to perform.

This PR tackles one of the first pet peeves I have about the precompile tool, which is that the name is not intuitive to what it does.

Transpile is a name that not everyone likes. Ultimately, converting one source code to another is also an act of "compilation"; in fact, the TypeScript tool that converts it into JavaScript is called the "TypeScript Compiler". The distinction between transpiler and compiler is blurry; but I think it is useful to call what we have as a transpiler to outline that it is doing a "source-to-source" translation, which I don't think a name like compile or precompile could.

Additionally, this PR moves the source files for the transpiler into its own package, gnovm/pkg/transpiler.

One question is to whether the "constants" of the precompiler, like GnoRealmPkgsPrefixBefore, should deserve their own package or not.

@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 47.47%. Comparing base (f8e67c1) to head (c3e8ff8).

Files Patch % Lines
gno.land/pkg/gnoclient/client_txs.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1681      +/-   ##
==========================================
- Coverage   47.48%   47.47%   -0.02%     
==========================================
  Files         385      385              
  Lines       61406    61379      -27     
==========================================
- Hits        29159    29140      -19     
+ Misses      29810    29804       -6     
+ Partials     2437     2435       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl merged commit 1065217 into master Feb 28, 2024
189 of 191 checks passed
@thehowl thehowl deleted the dev/morgan/precompile-refactor branch February 28, 2024 13:52
leohhhn pushed a commit to leohhhn/gno that referenced this pull request Feb 29, 2024
gnolang#1681)

Part 1 of several _transpiler_ refactors I intend to perform.

This PR tackles one of the first pet peeves I have about the
`precompile` tool, which is that the name is not intuitive to what it
does.

Transpile is a name that not everyone likes. Ultimately, converting one
source code to another is also an act of "compilation"; in fact, the
TypeScript tool that converts it into JavaScript is called the
"TypeScript Compiler". The distinction between transpiler and compiler
is blurry; but I think it is useful to call what we have as a
_transpiler_ to outline that it is doing a "source-to-source"
translation, which I don't think a name like `compile` or `precompile`
could.

Additionally, this PR moves the source files for the transpiler into its
own package, gnovm/pkg/transpiler.

One question is to whether the "constants" of the precompiler, like
`GnoRealmPkgsPrefixBefore`, should deserve their own package or not.
tbruyelle added a commit to tbruyelle/gnols that referenced this pull request Mar 3, 2024
tbruyelle added a commit to tbruyelle/gno that referenced this pull request Mar 3, 2024
Related to gnolang#1681

Gnols has been updated to reflect the command rename `precompile` to
`transpile`. The configuration options have been renamed accordingly.
Related commit: tbruyelle/gnols@2328330
tbruyelle added a commit to tbruyelle/gno that referenced this pull request Mar 3, 2024
Related to gnolang#1681

Gnols has been updated to reflect the command rename `precompile` to
`transpile`. The configuration options have been renamed accordingly.
Related commit: tbruyelle/gnols@2328330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants