Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): setup docker build cache #2062

Closed
wants to merge 6 commits into from
Closed

chore(ci): setup docker build cache #2062

wants to merge 6 commits into from

Conversation

albttx
Copy link
Member

@albttx albttx commented May 9, 2024

Build docker images as test, and let it for developers

@albttx albttx self-assigned this May 9, 2024
@albttx albttx requested review from moul and a team as code owners May 9, 2024 07:32
@albttx albttx requested review from ltzmaxwell and removed request for a team May 9, 2024 07:32
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.64%. Comparing base (bedd0f9) to head (59ae685).
Report is 197 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2062      +/-   ##
==========================================
- Coverage   54.65%   54.64%   -0.02%     
==========================================
  Files         583      583              
  Lines       78508    78508              
==========================================
- Hits        42909    42901       -8     
- Misses      32385    32393       +8     
  Partials     3214     3214              
Flag Coverage Δ
contribs/gnodev 23.81% <ø> (ø)
contribs/gnofaucet 15.31% <ø> (+0.85%) ⬆️
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 62.13% <ø> (ø)
gnovm 59.95% <ø> (ø)
misc/autocounterd 0.00% <ø> (ø)
misc/genproto 0.00% <ø> (ø)
misc/genstd 73.90% <ø> (ø)
misc/goscan 0.00% <ø> (ø)
misc/logos 17.38% <ø> (ø)
misc/loop 0.00% <ø> (ø)
tm2 54.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albttx albttx force-pushed the ci/docker-cache branch 2 times, most recently from 4383c92 to 84acee8 Compare May 9, 2024 09:16
@albttx
Copy link
Member Author

albttx commented May 9, 2024

After mutliple tries, i'm not sure it's improve a lot the build time.

probably because it's concurrent build.

@zivkovicmilos
Copy link
Member

@albttx can you please update the branch to the latest master and resolve conflicts? 🙏

@albttx
Copy link
Member Author

albttx commented Jun 13, 2024

@zivkovicmilos So i fixed / rebased this PR, and added a workflow that didn't push the Docker image (this can be remove if you want).

The idea is to add a simple dockerfile that could be use by dev (because the goreleaser version require the go toolchain locally, this is a more "pure" docker image where the binaries are built inside the images.

This Dockerfile is require for me for the ci/portal-loop test!

@ajnavarro
Copy link
Contributor

@zivkovicmilos is this still relevant?

@Kouteki
Copy link
Contributor

Kouteki commented Oct 8, 2024

@zivkovicmilos is this still relevant?

@sw360cab @zivkovicmilos the question still stands :)

@sw360cab
Copy link
Contributor

sw360cab commented Oct 8, 2024

@Kouteki I am working on a template of optimized image in the dedicated gno infra repository

@albttx
Copy link
Member Author

albttx commented Oct 8, 2024

This PR can be close

@albttx albttx closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants