Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): CI test of portal-loop #2064

Merged
merged 28 commits into from
Aug 22, 2024
Merged

chore(ci): CI test of portal-loop #2064

merged 28 commits into from
Aug 22, 2024

Conversation

albttx
Copy link
Member

@albttx albttx commented May 9, 2024

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@albttx albttx requested review from moul and a team as code owners May 9, 2024 09:36
@albttx albttx requested review from gfanton and removed request for a team May 9, 2024 09:36
@codecov Codecov
Copy link

codecov bot commented May 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.17%. Comparing base (5b768db) to head (a988174).
Report is 18 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2064   +/-   ##
=======================================
  Coverage   60.16%   60.17%           
=======================================
  Files         561      561           
  Lines       74999    74999           
=======================================
+ Hits        45122    45128    +6     
+ Misses      26502    26493    -9     
- Partials     3375     3378    +3
Flag Coverage Δ
contribs/gnodev 61.40% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
gno.land 64.75% <ø> (ø)
gnovm 64.13% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (ø)
tm2 62.07% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albttx albttx requested a review from a team as a code owner May 11, 2024 00:48
@albttx
Copy link
Member Author

albttx commented May 11, 2024

review is ready @zivkovicmilos :)

Full testing of portal loop :)

moul
moul reviewed May 12, 2024
View reviewed changes
.github/workflows/docker.yml Outdated Show resolved Hide resolved
moul
moul reviewed May 12, 2024
View reviewed changes
misc/loop/traefik/gno.yml Outdated Show resolved Hide resolved
@albttx
Copy link
Member Author

albttx commented May 12, 2024

Thanks @moul for review, everything is updated + pull origin master --no-rebase

zivkovicmilos
zivkovicmilos approved these changes May 26, 2024
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the CI, looks like it's failing on this new portal loop test (due to the latest release changes) 🙏

.github/workflows/portal-loop.yml Outdated Show resolved Hide resolved
.github/workflows/portal-loop.yml Outdated Show resolved Hide resolved
.github/workflows/portal-loop.yml Show resolved Hide resolved
@albttx
Copy link
Member Author

albttx commented May 27, 2024

blocked by #2199

@albttx albttx mentioned this pull request May 27, 2024
Merged
7 tasks
@Kouteki Kouteki requested a review from ajnavarro June 12, 2024 08:34
ajnavarro
ajnavarro previously requested changes Jun 12, 2024
View reviewed changes
.github/workflows/portal-loop.yml Outdated Show resolved Hide resolved
.github/workflows/portal-loop.yml Show resolved Hide resolved
.github/workflows/portal-loop.yml Show resolved Hide resolved
.github/workflows/portal-loop.yml Show resolved Hide resolved
@Kouteki Kouteki mentioned this pull request Jun 26, 2024
Open
@albttx albttx changed the title chore(ci): test start.sh for portal-loop chore(ci): CI test of portal-loop Jul 31, 2024
@albttx
Copy link
Member Author

albttx commented Jul 31, 2024

@ajnavarro @thehowl it's rebased :) ready for last review / merge

@thehowl thehowl requested a review from ajnavarro July 31, 2024 17:47
@thehowl
Copy link
Member

thehowl commented Jul 31, 2024

@ajnavarro I'll let you re-review as you already did it, feel free to ping me for another pair of eyes or second opinion :)

@ajnavarro
Copy link
Contributor

I am summoning @sw360cab for proper feedback.

sw360cab
sw360cab reviewed Aug 14, 2024
View reviewed changes
Dockerfile Show resolved Hide resolved
sw360cab
sw360cab approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@sw360cab sw360cab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would like to avoid using all this while...do bash stuff. However at the moment this looks as the most feasible solution for Portal loop needed checks.

.github/workflows/portal-loop.yml Show resolved Hide resolved
@zivkovicmilos zivkovicmilos dismissed ajnavarro’s stale review August 22, 2024 16:07

Antonio will forgive me, his review is stale 🙏

@zivkovicmilos zivkovicmilos merged commit e2a13e8 into master Aug 22, 2024
120 checks passed
@zivkovicmilos zivkovicmilos deleted the ci/portal-loop branch August 22, 2024 16:09
@thehowl thehowl mentioned this pull request Sep 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moul moul moul left review comments

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@sw360cab sw360cab sw360cab approved these changes

@gfanton gfanton Awaiting requested review from gfanton gfanton is a code owner automatically assigned from gnolang/tech-staff

@ajnavarro ajnavarro Awaiting requested review from ajnavarro ajnavarro is a code owner

Assignees

@albttx albttx

Labels
None yet
Projects
💪 Bounties & Worx
Status: Done
🧙‍♂️gno.land core team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@albttx @thehowl @ajnavarro @moul @sw360cab @zivkovicmilos