Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnoweb): added link to readme if present #2461

Merged
merged 7 commits into from
Aug 7, 2024

Conversation

agherasie
Copy link
Contributor

Added a link to the README.md file of the realm if it exists
image
To allow for quicker access while browsing gnoweb

This should solve #2458

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.11%. Comparing base (e844fc1) to head (fe9bc25).

Files Patch % Lines
gno.land/pkg/gnoweb/gnoweb.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2461      +/-   ##
==========================================
- Coverage   60.12%   60.11%   -0.01%     
==========================================
  Files         560      560              
  Lines       74690    74697       +7     
==========================================
- Hits        44905    44902       -3     
- Misses      26397    26402       +5     
- Partials     3388     3393       +5     
Flag Coverage Δ
contribs/gnodev 61.40% <ø> (ø)
contribs/gnofaucet 15.31% <ø> (ø)
gno.land 64.14% <57.14%> (-0.02%) ⬇️
gnovm 64.19% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 62.01% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gfanton
Copy link
Member

gfanton commented Jul 30, 2024

@agherasie can you fix bytes import on gnoweb pkg ? It should fix linting as well

Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! But you need to update your logic so it supports the scenario described in my comment below

gno.land/pkg/gnoweb/gnoweb.go Outdated Show resolved Hide resolved
@agherasie agherasie requested a review from gfanton July 30, 2024 13:51
@leohhhn leohhhn merged commit bbcb2f6 into gnolang:master Aug 7, 2024
115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants