-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnoweb): added link to readme if present #2461
feat(gnoweb): added link to readme if present #2461
Conversation
Co-authored-by: Lee ByeongJun <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2461 +/- ##
==========================================
- Coverage 60.12% 60.11% -0.01%
==========================================
Files 560 560
Lines 74690 74697 +7
==========================================
- Hits 44905 44902 -3
- Misses 26397 26402 +5
- Partials 3388 3393 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@agherasie can you fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! But you need to update your logic so it supports the scenario described in my comment below
Co-authored-by: Guilhem Fanton <[email protected]>
Added a link to the
README.md
file of the realm if it existsTo allow for quicker access while browsing gnoweb
This should solve #2458
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description