fix: In r/demo/profile fieldHandler, use url.QueryEscape(value) #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke the link Signed-off-by: Jeff Thompson <[email protected]>
jefft0
requested review from
ajnavarro and
ltzmaxwell
and removed request for
a team
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2642 +/- ##
==========================================
+ Coverage 54.99% 60.08% +5.09%
==========================================
Files 595 560 -35
Lines 79775 74750 -5025
==========================================
+ Hits 43872 44914 +1042
+ Misses 32581 26446 -6135
- Partials 3322 3390 +68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thehowl
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In r/demo/profile, if the Bio field is "My bio", then the web render for
r/demo/profile:f/g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5/Bioshows:The
[Edit]link doesn't display properly because of the space in "My bio". This PR updates fieldHandler to useurl.QueryEscape. With this fix the web render is as expected with the correct[Edit]link: