Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a ugnot constant #2656

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

deelawn
Copy link
Contributor

@deelawn deelawn commented Aug 3, 2024

Was starting to work on GNOT token locking and noticed we had no ugnot constant in our codebase. This PR adds a ugnot constant and replaces ugnot literals in most places.

@deelawn deelawn changed the title add a ugnot constant chore: add a ugnot constant Aug 3, 2024
@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Aug 3, 2024
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.12%. Comparing base (56f8357) to head (e2d2cb4).
Report is 19 commits behind head on master.

Files Patch % Lines
gno.land/pkg/gnoclient/signer.go 0.00% 1 Missing ⚠️
gno.land/pkg/integration/testing_node.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2656   +/-   ##
=======================================
  Coverage   60.11%   60.12%           
=======================================
  Files         560      561    +1     
  Lines       74911    74919    +8     
=======================================
+ Hits        45036    45042    +6     
- Misses      26498    26501    +3     
+ Partials     3377     3376    -1     
Flag Coverage Δ
contribs/gnodev 61.40% <100.00%> (ø)
contribs/gnofaucet 15.31% <ø> (+0.85%) ⬆️
gno.land 64.18% <85.71%> (+<0.01%) ⬆️
gnovm 64.13% <100.00%> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (+0.35%) ⬆️
tm2 62.03% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@aeddi aeddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this is the newbie. I'm trying to help with the overflow of open PRs. :)
I just asked a question about one file, but other than that, it looks good to me. 👍

gno.land/pkg/gnoland/ugnot/denom.go Show resolved Hide resolved
@deelawn deelawn merged commit 04d5239 into gnolang:master Aug 20, 2024
117 checks passed
@deelawn deelawn deleted the chore/ugnot-const branch August 20, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants