Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): update home page, add add test for r/events #2697

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Aug 14, 2024

Description

This PR updates the test4 item on the home page, and fixes a small rendering bug in the r/events realm, and adds tests to it.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@leohhhn leohhhn requested a review from moul as a code owner August 14, 2024 12:31
@leohhhn leohhhn self-assigned this Aug 14, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.15%. Comparing base (6fd4901) to head (58b5bfa).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2697   +/-   ##
=======================================
  Coverage   60.15%   60.15%           
=======================================
  Files         561      561           
  Lines       74999    74999           
=======================================
+ Hits        45112    45115    +3     
+ Misses      26510    26507    -3     
  Partials     3377     3377           
Flag Coverage Δ
contribs/gnodev 60.58% <ø> (ø)
contribs/gnofaucet 15.31% <ø> (+0.85%) ⬆️
gno.land 64.75% <ø> (ø)
gnovm 64.13% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 62.06% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leohhhn leohhhn added the don't merge Please don't merge this functionality temporarily label Aug 14, 2024
@leohhhn leohhhn removed the don't merge Please don't merge this functionality temporarily label Aug 14, 2024
@leohhhn leohhhn merged commit 763bdd1 into gnolang:master Aug 14, 2024
117 checks passed
@leohhhn leohhhn deleted the homepage/events branch August 14, 2024 14:55
MikaelVallenet pushed a commit to MikaelVallenet/gno that referenced this pull request Aug 17, 2024
…#2697)

## Description

This PR updates the test4 item on the home page, and fixes a small
rendering bug in the r/events realm, and adds tests to it.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [x] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants