-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP feat(gnovm): align Gno constant handling with Go specifications #2828
Open
omarsy
wants to merge
3
commits into
gnolang:master
Choose a base branch
from
TERITORI:fix/2628
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+323
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2828 +/- ##
==========================================
+ Coverage 63.08% 63.10% +0.02%
==========================================
Files 563 563
Lines 79254 79340 +86
==========================================
+ Hits 49998 50071 +73
- Misses 25896 25899 +3
- Partials 3360 3370 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
omarsy
force-pushed
the
fix/2628
branch
4 times, most recently
from
September 25, 2024 11:54
c9b02d2
to
f49c088
Compare
github-actions
bot
added
the
🧾 package/realm
Tag used for new Realms or Packages.
label
Sep 25, 2024
omarsy
force-pushed
the
fix/2628
branch
2 times, most recently
from
September 26, 2024 10:31
355d799
to
e9a9be7
Compare
omarsy
requested review from
jaekwon,
moul,
piux2,
thehowl,
mvertes and
a team
as code owners
October 18, 2024 20:52
omarsy
changed the title
feat(gnovm): align Gno constant handling with Go specifications
WIP feat(gnovm): align Gno constant handling with Go specifications
Oct 18, 2024
@omarsy , can you fix the lint-pr-title CI check? |
jefft0
added
the
review/triage-pending
PRs opened by external contributors that are waiting for the 1st review
label
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📦 🤖 gnovm
Issues or PRs gnovm related
🧾 package/realm
Tag used for new Realms or Packages.
review/triage-pending
PRs opened by external contributors that are waiting for the 1st review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues:
#2628
This PR aims to align Gno's constant handling with the Go specification regarding constant expressions (see Go Specification on Constants).
Primitive Type Requirement
Function Calls Disallowed
Only built-in functions should be allowed.
Constant Operands Requirement
Constant expressions may contain only constant operands and are evaluated at compile time.
Type Assertion Forbidden
Index Expression Forbidden
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description