Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in p/demo/blog imports #921

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

harry-hov
Copy link
Contributor

Description

Currently master is failing because #882 was merged and there was a typo in /p/demo/blog's gno.mod file. which is leading to import cycle error. Fixed it.

Since we are now automatically loading pkgs from /examples when the chain starts. Can we trigger gno.land/test even on package/realm change? To prevent such oversights in the future.

@harry-hov harry-hov requested a review from a team as a code owner June 20, 2023 19:19
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jun 20, 2023
@harry-hov harry-hov added 📦 ⛰️ gno.land Issues or PRs gno.land package related hotfix labels Jun 20, 2023
@schollz
Copy link
Contributor

schollz commented Jun 20, 2023

Thanks I was just about to note this too

@thehowl
Copy link
Member

thehowl commented Jun 21, 2023

Since we are now automatically loading pkgs from /examples when the chain starts. Can we trigger gno.land/test even on package/realm change? To prevent such oversights in the future.

Agreed. Merging this :)

@thehowl thehowl merged commit 8cf97dd into gnolang:master Jun 21, 2023
Doozers pushed a commit to Doozers/gno that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants