Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

[1.8.0] Tokens' description in still contains 'xDAI' #2036

Closed
elena-zh opened this issue Dec 23, 2021 · 6 comments
Closed

[1.8.0] Tokens' description in still contains 'xDAI' #2036

elena-zh opened this issue Dec 23, 2021 · 6 comments
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link

Originally reported in #2023 (review)
Related to gnosis/gp-ui#919

Tokens in the token list show xDAI
token list

The same is for token names when import custom tokens
import token
@elena-zh elena-zh added app:CowSwap CowSwap app Low Severity indicator for defects. It won't cause any major break-down of the system Bug Something isn't working labels Dec 23, 2021
nenadV91 pushed a commit that referenced this issue Jan 3, 2022
@moodysalem @JFrankfurt
fix(L2): enable optimism token list when switched to optimism (#2036)
a186833 
* add title text and opacity variability to token lists

* add optimism token list

* show tokens from active lists

* sort up token lists
with tokens on the current chain

* fix up some type issues

prune out chainId changes

* clean up leftover any

* refactor token count mechanism

* handle plurals in title text string

* new combineMaps implementation

* remove custom plural

* address a couple nits

* show the number of tokens on current chain

Co-authored-by: Jordan Frankfurt <[email protected]>
Co-authored-by: Justin Domingue <[email protected]>
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you think it shouldn't be closed, speak now or forever hold your peace.

@stale stale bot added the wontfix Stale issue label Mar 2, 2022
@elena-zh
Copy link
Author

elena-zh commented Mar 2, 2022

@alfetopito , @anxolin , will we be able to fix this?
If the issue is not on our side, we can close this issue...

@stale stale bot removed the wontfix Stale issue label Mar 2, 2022
@alfetopito
Copy link
Contributor

We can still do a renaming on the frontend

Simple regex match on xdai and replace it with on Gnosis Chain, or from Ethereum

@anxolin
Copy link
Contributor

anxolin commented Mar 4, 2022

But this comes from the token lists, right? I would not change it. We could reach the token lists and tell them to update the description

I guess this one is honeyswap

@anxolin
Copy link
Contributor

anxolin commented Mar 4, 2022

Created an issue in HoneySwap, I don't think we should do any regex replacement on our side 1Hive/honeyswap#154

@alfetopito
Copy link
Contributor

I thought that was coming from the contract, not from the list 🤔

In that case, we can wait for them and close the issue on our side.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alfetopito @anxolin @elena-zh