Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

[1.10] Message about available claims appear when a user has already claimed #2382

Closed
elena-zh opened this issue Feb 3, 2022 · 1 comment · Fixed by #2394
Closed

[1.10] Message about available claims appear when a user has already claimed #2382

elena-zh opened this issue Feb 3, 2022 · 1 comment · Fixed by #2394
Assignees
Labels
app:CowSwap CowSwap app Bug Something isn't working Claim Issues related to 'Claim' feature Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link

elena-zh commented Feb 3, 2022

The app says me that I have available claims in GC (for connected and disconnected scenario), but I have already claimed all options there and get 0 tokens to claim when switch to GC. See the video: https://watch.screencastify.com/v/3pkTurEDNCzjTMNk8ISn

Expected: do not show warning message when a user has already claimed in that network and has 0 vCOW tokens to claim.

@elena-zh elena-zh added app:CowSwap CowSwap app Claim Issues related to 'Claim' feature Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Bug Something isn't working labels Feb 3, 2022
@elena-zh elena-zh changed the title Message about available claims appear when a user has already claimed [1.10] Message about available claims appear when a user has already claimed Feb 3, 2022
@alfetopito alfetopito self-assigned this Feb 3, 2022
@alfetopito
Copy link
Contributor

I've tried one solution to solve this but then I realized it won't work.

There might be a way to check but it might be not as trivial as I thought.

At a bare minimum, what I could do it update the state when you go to a network where you are supposed to have claims but the claims are no longer available/claimed. Then when you go to another network it'll no longer show.

I'll give that a try

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Bug Something isn't working Claim Issues related to 'Claim' feature Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants