Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Moved claim state updater to claim page #2380

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

alfetopito
Copy link
Contributor

Summary

Moving claim state updater to claim page

Since #2342 has been superseded, I'm re-using a fix I did there that's useful.

We don't need to check whether the active claim account has claim on mainnet and gchain unless we are on the claim page.

To Test

  1. Claim in other network detection should behave the same as before

@alfetopito alfetopito self-assigned this Feb 2, 2022
@alfetopito alfetopito requested review from a team February 2, 2022 22:42
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

elena-zh commented Feb 3, 2022

Hey @alfetopito ,
the app says me that I have available claims in GC (for connected and disconnected scenario), but I have already claimed all options there and get 0 tokens to claim when switch to GC. See the video: https://watch.screencastify.com/v/3pkTurEDNCzjTMNk8ISn

However, it appears that the issue is reproducible in Stage. I have reported it as a separate issue: #2382

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claim in other network detection behaves the same as before (incl. #2344 and mentioned above issues)

@alfetopito alfetopito merged commit e7feb5d into develop Feb 3, 2022
@alfetopito alfetopito deleted the move-claim-updater-to-claim-page branch February 3, 2022 17:18
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

ramirotw pushed a commit that referenced this pull request Feb 18, 2022
…2380)

* refactor: transaction info is translated in the appropriate places

fixes Uniswap/interface#1756

* getting closer

* more work

* finished, finally

* bit more refactoring

* move summary into its own file

* little more cleanup in the transaction summary file

* fix bad copy

* fix the migrate notification

* missing translation

* fix the language for vote and address other pr comments

* fix typo

* - remove old transactions with this update
- change to present tense
- show ens name where appropriate

* add a test that shows we don't clear old ones
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants