Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Warning about limited ETH balance is not displayed when several options to claim are selected #2405

Closed
elena-zh opened this issue Feb 8, 2022 · 1 comment
Closed

Warning about limited ETH balance is not displayed when several options to claim are selected #2405

elena-zh opened this issue Feb 8, 2022 · 1 comment
Labels
app:CowSwap CowSwap app Bug Something isn't working Claim Issues related to 'Claim' feature Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link

elena-zh commented Feb 8, 2022

Related to #2395

Warning about limited ETH balance is not displayed when several options to claim are selected, and there are several additional validation errors are on the screen.
See the video: the warning blinks, then disappears https://watch.screencastify.com/v/h0TTY9P6U9oPjNxlFPck

Expected: the warning should be displayed
image.png
@elena-zh elena-zh added app:CowSwap CowSwap app Claim Issues related to 'Claim' feature Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system and removed Medium Severity indicator. It causes some undesirable behavior, but the system is still functional labels Feb 8, 2022
@elena-zh
Copy link
Author

elena-zh commented Feb 8, 2022

Seems that it was an issue related to #2407 fix.
No longer reproducible.

@elena-zh elena-zh closed this as completed Feb 8, 2022
ramirotw pushed a commit that referenced this issue Feb 18, 2022
@zzmp
perf(i18n): bundle default locale with main chunk (#2405)
9b1903d 
* fix(i18n): do not defer render on locale

Do not defer render on locale load. This delays the initial render of the page, effectively delaying to LCP.
Lingui allows the page to render with no text while a locale is loading. A fallback locale is only used when loading a locale fails - not while it is pending.

* perf(i18n): include default language in initial bundle
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
app:CowSwap CowSwap app Bug Something isn't working Claim Issues related to 'Claim' feature Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elena-zh