1inch issue signing

[anxolin]

Describe the bug
Wrapping ETH and approving WETH worked.

Failed when I tried to sign.

How to Reproduce
To reproduce, install 1inch app, and connect using wallet connect. Tested in IOS

When signing:

[alfetopito]

iOS only wallet
Probably we could make it use a different signing method if we can find out which error exactly it returns
Disabling it for now on #701

[anxolin]

@alfetopito In this case, we are getting an error back from the wallet. In this case, shouldn't this be triggering the fallback logic?

[anxolin]

Debugged this a bit more, because I suspected that maybe the error was in WC library handling the error, but we are seeing the original error sent by 1inch:

[anxolin]

I tried with v4, v3, ethsign, and same result for all of them. Just leaving this issue open and deprioritizing.

I contacted 1inch through their chat, to notify them about the issue, plus created this PR to leave it open for wallets to try to debug the errors #718 (since main branches have the wallets disabled)

[anxolin]

UPDATE: The support team says that they solved this, now they implement EIP-712 but still needs to pass QA and deploy to production (needs apple signature)

[alfetopito]

@anxolin I think this is fixed, right?

[anxolin]

Not in IOS....

[elena-zh]

Hey @anxolin , the issue is still relevant in v 1.5.0: I can wrap/unwrap tokens using 1Inch wallet, but I can't sign an order.
https://watch.screencastify.com/v/x6O8F5nCmPi4VPwLE2WW

[elena-zh]

In a mobile view I can't even wrap/unwrap: I can't see confirmation modal in the connected wallet:

1Inch.mp4

Updated: confirmation modal appears, but it is hidden under connection modal.
So terrible UI 😕
The same as for desktop, it is impossible to sigh an order from there.

[podkovyrin]

@elena-zh you just need to tap the Hide button in the top left. Though I agree that might be not clear. We will improve UX here, thanks.

[elena-zh]

@podkovyrin , yes, thank you. I understood it in a while,.
Then, I was able to run some transactions.

Thanks!

[anxolin]

Okay, nice so u were able to complete all the workflows with 1inch?

Then we should re-enable it in production, although it would be good to make it more obvious how to close it as @podkovyrin pointed out.

[elena-zh]

1Inch wallet works as expected and has been enabled in v1.6.0