This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Enable 1inch #1942
Merged
Enable 1inch #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
elena-zh
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Hey @anxolin , it works!
I'm able to connect the wallet using WC in both desktop and mobile versions, run all types of transactions from there.
Also, the app works as expected in 1Inch integrated browser.
The only issue I have found is that 'Connected with Metamask' is displayed in the Activity modal when the connected in the integrated browser. But I have reported this issue yesterday in #1938
alfetopito
approved these changes
Nov 30, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-enable 1inch over Wallet Connect
1inch fixed their signing issues, and now should be working. Their UI is still improbable, it lead us to believe the WC window could not be closed, so it was not possible to complete a workflow.
See comment:
#700 (comment)
To Test