[Affiliate] Close all affiliate banners after a successful trade #1748
Conversation
matextrem
added
Bug
matextrem
changed the title
|
There was a problem hiding this comment.
Hi @matextrem ,
Now the banner disappears when sign an order.
However, along with the banner, an order info is not displayed in the activity side bar.
Moreover, the banner disappears on the 'Sign' order event, and it is not correct, as the order can be 'Expired' or 'Cancelled', and will not be included into trades list.
Also, info banners do not appear for a while for the account even if I follow another referral link.
So, my expected result for the issue is:
- Close info banner as soon as a user places a successful trade.
- Do not clear out recent activities from the local storage
|
I won't include this PR in release/1.4 since it has unaddressed issues. One the release is closed, pls repoint this PR to develop branch |
… into 1707/invalid-code-message
There was a problem hiding this comment.
In this PR I see a lot of requests sent to the BE.
As the result, BE starts blocking requests and fails to load profile data
https://watch.screencastify.com/v/vdi1v61D3xta8nkV7U8M
| import { ButtonSecondary } from 'components/Button' | ||
| import { OrderStatus } from '@src/custom/state/orders/actions' |
There was a problem hiding this comment.
Does it work with the previous import path?
|
Hi @matextrem , now I still see a previous banner after a successful trade. It remains to be displayed until I reload the page. The video is recorded for another issue I'm going to report, but here you can see the described behavior above |
alfetopito
added
the
Auto-merge
Fixes #1707 Remove info banner when order is recently fulfilled. 1. Navigate through a referral link with a new account. - You will see `Valid Affiliate code: You can now do your first trade to join the program` banner message 2. Under the new account do the 1st trade in the mainnet. - Information banner will disappear
Fixes #1707 Remove info banner when order is recently fulfilled. 1. Navigate through a referral link with a new account. - You will see `Valid Affiliate code: You can now do your first trade to join the program` banner message 2. Under the new account do the 1st trade in the mainnet. - Information banner will disappear
Co-authored-by: Crowdin Bot <[email protected]>
Summary
Fixes #1707
Remove info banner when order is recently fulfilled.
To Test
Valid Affiliate code: You can now do your first trade to join the programbanner message