-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also do the one for buying ETH and sending it to a Smart Contract?
To add: issue number #1612 |
no clue how to test it works tho, please let me know if it's ok |
// https://github.com/gnosis/gp-v2-services/blob/0bd5f7743bebaa5acd3be13e35ede2326a096f14/orderbook/openapi.yml#L562 | ||
// https://github.com/gnosis/gp-v2-services/blob/d932e11c9a2125fdba239530be7684799f694909/crates/orderbook/openapi.yml#L801 | ||
// and | ||
// https://github.com/gnosis/gp-v2-services/blob/d932e11c9a2125fdba239530be7684799f694909/crates/orderbook/openapi.yml#L740 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice you add the blob. As a nitpick, I would also make a comment with something: See latest version and a link to their main branch file where they always have the latest
This way we can easily check if there's sth new
@W3stside should we include this one in 1.5 too? |
Elena tested it already, but it's easy: Try to place and order with Gnosis Safe or add as recipient a SmartContract address |
e478c22
to
44da786
Compare
@W3stside i just rebased your branch to 1.5 and merged, i hope is alright |
@anxolin all good was going to do the same, thanks |
Simple signposting, for issue #1896
Summary
Adds latest errors found in newest API spec from here: https://github.com/gnosis/gp-v2-services/blob/main/crates/orderbook/openapi.yml#L740
Screenshot:
TEST