Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Add latest backend errors to cowswap #1896

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Conversation

W3stside
Copy link
Contributor

Summary

Adds latest errors found in newest API spec from here: https://github.com/gnosis/gp-v2-services/blob/main/crates/orderbook/openapi.yml#L740

Screenshot:
image

TEST

  1. XDAI chain
  2. select 0xMR as in and XGTv2 as out
  3. trade
  4. should see insufficient liquidty error as opposed to Error try again later error

@W3stside W3stside requested review from a team November 21, 2021 17:01
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

Copy link

@MareenG MareenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely.

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also do the one for buying ETH and sending it to a Smart Contract?

@elena-zh
Copy link

Could you also do the one for buying ETH and sending it to a Smart Contract?

To add: issue number #1612

@W3stside
Copy link
Contributor Author

W3stside commented Nov 23, 2021

@alfetopito e478c22

no clue how to test it works tho, please let me know if it's ok

// https://github.com/gnosis/gp-v2-services/blob/0bd5f7743bebaa5acd3be13e35ede2326a096f14/orderbook/openapi.yml#L562
// https://github.com/gnosis/gp-v2-services/blob/d932e11c9a2125fdba239530be7684799f694909/crates/orderbook/openapi.yml#L801
// and
// https://github.com/gnosis/gp-v2-services/blob/d932e11c9a2125fdba239530be7684799f694909/crates/orderbook/openapi.yml#L740
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice you add the blob. As a nitpick, I would also make a comment with something: See latest version and a link to their main branch file where they always have the latest

This way we can easily check if there's sth new

@elena-zh
Copy link

Seems that it works: at least, the explanation is much better than it was before.
image

@anxolin
Copy link
Contributor

anxolin commented Nov 23, 2021

@W3stside should we include this one in 1.5 too?

@alfetopito
Copy link
Contributor

@alfetopito e478c22

no clue how to test it works tho, please let me know if it's ok

Elena tested it already, but it's easy: Try to place and order with Gnosis Safe or add as recipient a SmartContract address

@anxolin anxolin changed the base branch from develop to release/1.5 November 23, 2021 19:12
@anxolin
Copy link
Contributor

anxolin commented Nov 23, 2021

@W3stside i just rebased your branch to 1.5 and merged, i hope is alright

@anxolin anxolin merged commit dda5cef into release/1.5 Nov 23, 2021
@W3stside
Copy link
Contributor Author

@anxolin all good was going to do the same, thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants