This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
[ABA - fixes] - Fix warning showing when not needed, and show correct impact in modal #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anxolin @gnosis/gp-frontend merging to consolidate please post merge review |
|
|
@W3stside , confirmation modal looks good. Still, Text color in warnings is different Then, I see jumping price impact |
This was referenced Dec 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes [ABA] Parallel BA request + naive formula + warning messages #1953 (comment) addressed by @elena-zh
Fixes price impact showing fiat in modal
softer message as outlined by @anxolin here: [ABA] Parallel BA request + naive formula + warning messages #1953 (comment)
To Test