Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Bump dex-js to 0.13.0 to fix issue with trailing dot #1967

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Bump dex-js to 0.13.0 to fix issue with trailing dot #1967

merged 2 commits into from
Dec 6, 2021

Conversation

alfetopito
Copy link
Contributor

Summary

Fixes #1316

The actual fix was on dex-js gnosis/dex-js#300

This change is simply bumping the lib version on CowSwap

To Test

  1. Pick a pair and fill in an absurd high amount
  2. Wait until the receive amount is something that ends in .0 - well, you actually won't see that because you should see instead no trailing dots nor zeros

@alfetopito alfetopito self-assigned this Dec 3, 2021
@alfetopito alfetopito requested review from a team December 3, 2021 21:45
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@W3stside W3stside added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Dec 6, 2021
elena-zh
elena-zh approved these changes Dec 6, 2021
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit fc98999 into develop Dec 6, 2021
@alfetopito alfetopito deleted the 1316/trailing-dot branch December 13, 2021 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@W3stside W3stside W3stside approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees

@alfetopito alfetopito

Labels
Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trailling . on formatted amounts
3 participants
@alfetopito @W3stside @elena-zh