[ABA impact] - Re-enable Fiat Price Impact + minor optimisations

[W3stside]

Re-enables the fiat price impact.

1. Fiat Price Impact > Fallback ABA Price Impact
2. Minor optimisations to UI/UX

Testing

1. should get fiat price impacts
2. XDAI should still calc fallback price impact on some pairs that dont have fiat (WXDAI <> 1INCH)

[github-actions]

• 🔭 GP Swap: Gnosis Protocol v2 Swap UI

[W3stside]

@elena-zh this PR doesn't have the logic from #1985 so you will see jumping values here.

[elena-zh]

Hey @W3stside , is this OK to see the message along with a price impact value?

I'm clarifying due to it is a bit unclear to me what else, besides displaying price impacts even without USD estimations, to test.

[W3stside]

Hey @W3stside , is this OK to see the message along with a price impact value?

I'm clarifying due to it is a bit unclear to me what else, besides displaying price impacts even without USD estimations, to test.

hmm interesting, let me review this

[elena-zh]

Hey @W3stside , great! Now the message is displayed only if a price impact is missing.
But could we do anything with this jumping message effect (see the video from 00:09 sec):

blink.mp4

[W3stside]

Hey @W3stside , great! Now the message is displayed only if a price impact is missing. But could we do anything with this jumping message effect (see the video from 00:09 sec):

blink.mp4

should be fixed when #1985 is merged together

[W3stside]

@gnosis/gp-qa @gnosis/gp-frontend I am preemptively merging please post merge review

[W3stside]

rebased #1984 which has #1985

[anxolin]

Not related to this PR, but I didn't know in which to write it.

If you are connected, we fail to show the user if there's an issue with the price:

[elena-zh]

Hey @W3stside , I see an eternal loader when I select From token and its amount, but has not yet selected To token.
And vice versa: To+amount is specified, no From token.

I think, we could show it when a token pair and an amount are specified.

[elena-zh]

Also, I can see an eternal loader when all tokens and amounts are specified. Sometimes I can't even press on the Swap button when the impact is being loaded (in regular mode):

This might be a result of failed BE requests or so.. But as an option, could we set something like a timer for this loading indicator?
If we do not get a calculation when timer's countdown ends, just show a warning that price impact is unknown.
@W3stside , @anxolin , WDYT?

[W3stside]

@elena-zh infinite loader is fixed in latest commit

[elena-zh]

@W3stside , this issue

I see an eternal loader when I select From token and its amount, but has not yet selected To token.
And vice versa: To+amount is specified, no From token.

has been fixed.

But still I can face this issue

[elena-zh]

Hey @W3stside , I have been able to face this: I see Price impact in percentage, but get price impact unknown warning. This is due to buy amount is too low to cover fees for the inverse sell order.

I think we shouldn't show percentage in this case.

The same is when there is insufficient liquidity for an inverse trade

Actually, it might be displayed even when there is enough liquidity for both trades, and amounts cover fees

I might assume that this is due to price/quotes loading errors...

[elena-zh]

Also, I noticed that tokens' USD estimation appears disappears on the form (XDAI network)
https://watch.screencastify.com/v/LXxwuxocGvZWVVFz2GFe

[elena-zh]

Not related to this PR, but I didn't know in which to write it.

If you are connected, we fail to show the user if there's an issue with the price:

Reported as a separate issue #1989

[elena-zh]

Changes LGTM besides this warning flashing issue
https://watch.screencastify.com/v/omnuebGgf9WziElOXQWi

@W3stside , let me know please if I need to create a separate issue for this case.

Thanks

[anxolin]

Seems alright to me, if this passes Elena tests im good :)

Some unrelated issue I see, is that ABA won't show ever more than 50%, when in reality it could be 100%

[W3stside]

merging after successful build (addressed @Anxo comments)

[elena-zh]

Seems alright to me, if this passes Elena tests im good :)

Some unrelated issue I see, is that ABA won't show ever more than 50%, when in reality it could be 100%

@anxolin , we have an issue for this on the board: #1979

Actually, the max 49.99% price impact appears when there is insufficient liquidity for the inverse trade