Feature/1708 affiliate link owner info show

[maria-vslvn]

Summary

<<if there's an issue>>Fixes #1708

add and modify the affiliate link owner info display ate the profile page

To Test

1. Open the page Profile
   Checkout the new display and updates

[github-actions]

• 🔭 GP Swap: Gnosis Protocol v2 Swap UI

[elena-zh]

Hey @maria-vslvn ,

some issues:

1. It would be nice to hide the field when a user is not connected to the Mainnet, as referral data is available only there
   

2. It would be great to hide the field if a user has not traded before
   

3. No need to show this link to a user with trades, and these trades were done without a referral link

4. Referral link can't be the connected address. The value is the address that is uploaded to ipfs when a user follows a referral link

5. Seems that the fields are not placed in 1 horizontal line on the form
   

6. Mobile and tablet views are changed in this PR. It would be great to leave them as they are currently deployed in Prod
   
   

[ramirotw]

@maria-vslvn you should pick the referral address by using the hook useReferralAddress.

And btw there's a typo in Reffered -> Referred

[ramirotw]

👍

[alfetopito]

Minor comment, otherwise looking good to me.

Would just make sure Elena's comments are addressed

[elena-zh]

Hi @maria-vslvn , cases 1-4 from the comment above #2026 (review) are still not fixed.
The purpose of the current issue is to show a user an address he/she has followed, and under which he/she has done a trade. This value (referral address) should be taken from the BE.
In this PR I see that you are trying to show the new referral link, that is currently active, and is stored in the local storage.
I assume, that is why all these issues are still not fixed.

Thanks.

[elena-zh]

We still do not indicate under which link the 1st trade was done.

[matextrem]

@ramirotw @alfetopito Which is the endpoint needed to retrieve the referrer user? Trades enpoint does not return any information related to that.

[ramirotw]

@ramirotw @alfetopito Which is the endpoint needed to retrieve the referrer user? Trades enpoint does not return any information related to that.

I believe the way we could do that is:

1. get the user first trade by using the /trades endpoint
2. using the orderId from that trade query the /orders/{uid}
3. using the appData from the order response, we could use the decode helper @alfetopito implemented in https://codepen.io/pacara/pen/BadZgjg (this should be part of the sdk btw)
4. extract the referrer address from there

does that makes sense @alfetopito or we have a simpler and better way to do it?

[alfetopito]

@ramirotw @alfetopito Which is the endpoint needed to retrieve the referrer user? Trades enpoint does not return any information related to that.

I believe the way we could do that is:

1. get the user first trade by using the /trades endpoint

2. using the orderId from that trade query the /orders/{uid}

3. using the appData from the order response, we could use the decode helper @alfetopito implemented in https://codepen.io/pacara/pen/BadZgjg (this should be part of the sdk btw)

4. extract the referrer address from there

does that makes sense @alfetopito or we have a simpler and better way to do it?

Yeah, that sounds about right.
Don't think there's an easier way right now.

[alongoni]

Looks great!

[alfetopito]

Regarding the first point from Elena comment and talking to Rami, a solution for this would be trying to getTrades pointing to the default env (i.e: barn). If getTrades does not returns anything, try with prod environment.

WDTY is the best approach to handle it @alfetopito ?

CC: @ramirotw

I was sure something like that had already been implemented for the affiliate program, before we upload it to IPFS, but looking at the code right now I couldn't find it.

Did we just talk about it but did not actually implement it?

Anyway, I think this would make sense for both but could be a follow up PR

[matextrem]

@alfetopito You mean this ticket? #1819. @elena-zh shared it to me but I was unsure if it was the same case.

[alfetopito]

@matextrem I've raised this internally with the backend team to check for an alternative solution.

Will let you know when I get an answer

[matextrem]

@elena-zh @alfetopito updated!

[matextrem]

I have read the CLA Document and I hereby sign the CLA

[matextrem]

recheckcla

[elena-zh]

Hey @matextrem , seems that the last your commit was not properly merged as I still can't see a referree for an account with trades in the Prod server

@alongoni , WDYT about left-aligning all these elements in a mobile view like we do for the tablet view?

Also, it would be nice to make have a common style: currently, icons, fields' labels have different sizes, colors, etc.

[alfetopito]

General comment for both fns: there seems to be a lot of anys. Don't we know the types returned?

[matextrem]

There seems to be a problem with Promise.allSettled and typing (https://stackoverflow.com/a/67533949) . I tried the solution suggested there but I was not able to make it work with our current eslint configuration so I have to type those cases with any

[alongoni]

Regarding styles:

@matextrem you can check the CSS here:

https://www.figma.com/file/bcoZf5RIgVKDItdOaTZq18/GP-Swap?node-id=3581%3A697

Not sure yet about left-aligning all elements (Referred by + Last updated + View all orders). I'll check it in a prototype on figma.

[elena-zh]

Hey @matextrem , great changes!

The last thing that I have noticed today is that the account referee info is not auto-removed when switch to another account without trades/referral code. See the video: https://watch.screencastify.com/v/xHXmzYwUEKS80xTjMmWU

Could you please fix this?

[matextrem]

@elena-zh Updated!

[elena-zh]

LGTM now!

[alfetopito]

As was discussed in the last sync meeting, we decided to not proceed with this feature.

Thanks for the effort everyone, but unfortunately it won't go live.