This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
vCow contracts #2029
Merged
vCow contracts #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
W3stside
reviewed
Dec 21, 2021
|
@alfetopito does the auto-generated type stuff have auto compile in package json? where is it coming from |
W3stside
approved these changes
Dec 22, 2021
No, because the default path is for Uniswap contracts. I don't think we need to re-generate them every time and also it would overwrite some custom changes we need, namely exporting the originally generated exports. |
nenadV91
pushed a commit
that referenced
this pull request
Jan 3, 2022
* revert to remove ui polish changes * left align blurb and fix bp issue * fix translation wrapper * remove preview screen for create, hide submitted txn UI for create, copy updates * small fixes * copy updates for create blurb * add set price range title * add translation * fix some translations Co-authored-by: Justin Domingue <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added vCow related stuff
ABI
Generated types
Temporary Rinkeby address
Hook
To Test
No testing possible yet