Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Claim refactor index redux #2077

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Claim refactor index redux #2077

merged 3 commits into from
Jan 11, 2022

Conversation

nenadV91
Copy link
Contributor

Summary

Adding on David's PR #2072, to use redux instead of context

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@nenadV91 nenadV91 marked this pull request as ready for review January 11, 2022 15:06
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool nenad! I like what you did here. Good job

I see you even killed the booleans with mutually-exclusive state

@@ -1,5 +1,12 @@
import { createAction } from '@reduxjs/toolkit'

export enum ClaimStatus {
DEFAULT = 'DEFAULT',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpic: Maybe

  • NOT_CLAIMING
  • SIGNING
  • SUBMITTED
  • CLAIMED

@anxolin anxolin merged commit 224dab3 into claim Jan 11, 2022
@alfetopito alfetopito deleted the claim-refactor-index-redux branch January 11, 2022 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants