Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Dropdown component for vCOW balance #2156

Merged
merged 24 commits into from
Jan 24, 2022
Merged

Dropdown component for vCOW balance #2156

merged 24 commits into from
Jan 24, 2022

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented Jan 14, 2022 •
edited
Loading

Summary

Fixes #2007, #2076
image

Test

Open the profile page and check the vCOW dropdown.

@alongoni alongoni added app:CowSwap CowSwap app Protofire Handled by Protofire development team Claim Issues related to 'Claim' feature labels Jan 14, 2022
@alongoni alongoni self-assigned this Jan 14, 2022
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@alongoni alongoni marked this pull request as ready for review January 18, 2022 19:02
@elena-zh
Copy link

Hi @alongoni , great changes!
Some things to improve from my perspective:

  1. Maybe we shouldn't open the dropdown if we have an empty vCOW balance?
    image

  2. I'd prefer to see all list options left-aligned, maybe 'Total' in bold Something like:
    image

  3. Btw, maybe we should expand the form to cover the whole section's width in a mobile view. WDYT?
    image

@elena-zh
Copy link

elena-zh commented Jan 20, 2022 •
edited
Loading

hey @alongoni , I have claimed vesting tokens, but I was not able to see them in the dropdown: I can't open it
image

I tested with account 0x6B73dc97554b78BFdb01bcAf7F0770Fd430bec33
TxHash is https://rinkeby.etherscan.io/tx/0x873fb463980c80bbf82038b81021b5ce3c75af0d1a09eb2cb417cfc808129935

@anxolin anxolin changed the base branch from claim to develop January 20, 2022 17:41
@anxolin
Copy link
Contributor

anxolin commented Jan 20, 2022 •
edited
Loading

@alongoni i changed the base branch to develop since now we are aggregating all that has to do with the claiming there.

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@alongoni
Copy link
Contributor Author

Please @elena-zh can you test it again? Thanks!

@elena-zh
Copy link

Hey @alongoni , looks good to me, especially in a desktop view.

I'm a bit concerned about a mobile version: numbers do not seem to me aligned
image

Besides, it would be nice to adjust the dropdown's width to the main balance field when an amount is a long one
image

elena-zh
elena-zh approved these changes Jan 21, 2022
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ramirotw ramirotw merged commit f5fe248 into develop Jan 24, 2022
@ramirotw ramirotw deleted the 2007-vCOW-balance-dropdown branch January 24, 2022 13:31
@elena-zh elena-zh mentioned this pull request Jan 25, 2022
Closed
@alfetopito alfetopito mentioned this pull request Jan 25, 2022
Merged
@alongoni alongoni mentioned this pull request Feb 7, 2022
Closed
@elena-zh elena-zh mentioned this pull request Feb 17, 2022
Open
@anxolin anxolin mentioned this pull request Apr 2, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ramirotw ramirotw ramirotw approved these changes

@elena-zh elena-zh elena-zh approved these changes

@henrypalacios henrypalacios Awaiting requested review from henrypalacios

@maria-vslvn maria-vslvn Awaiting requested review from maria-vslvn

Assignees

@alongoni alongoni

Labels
app:CowSwap CowSwap app Claim Issues related to 'Claim' feature Protofire Handled by Protofire development team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add vCOW balance to Profile
4 participants
@alongoni @elena-zh @anxolin @ramirotw