Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Further styling of investment flow #2192

Merged
merged 4 commits into from
Jan 19, 2022
Merged

Further styling of investment flow #2192

merged 4 commits into from
Jan 19, 2022

Conversation

fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Jan 18, 2022 •
edited
Loading

Summary

  • Investment flow styling (still WIP)
  • Better color support between light/dark mode.

Screen Shot 2022-01-18 at 18 00 12

Note

  • Many todos pending

Screen Shot 2022-01-18 at 17 20 42

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@fairlighteth fairlighteth requested review from a team January 18, 2022 17:04
@fairlighteth fairlighteth changed the base branch from claim to claim-styleImprove-11 January 18, 2022 17:04
@alfetopito
Copy link
Contributor

FYI, it's a bit broken on FF
Screen Shot 2022-01-18 at 10 24 36

@anxolin
Copy link
Contributor

anxolin commented Jan 18, 2022

Same as leandro. Weird, cause it looked nice in your laptop

@elena-zh
Copy link

I have more or less nice views on FF on the Claim form, but I do not see changes from the screenshot above:

  • I do not see airdrop option
  • Investment grids look like previous ones to me in this PR
    image

@alfetopito
Copy link
Contributor

I have more or less nice views on FF on the Claim form, but I do not see changes from the screenshot above:

* I do not see airdrop option

* Investment grids look like previous ones to me in this PR
  ![image](https://user-images.githubusercontent.com/70885163/150001668-04ea143d-c1dc-4327-8fcc-1eec0b8c0c9a.png)

It's a different screen Elena.
The one we are talking about is the last one, after the approval screen

@elena-zh
Copy link

I have more or less nice views on FF on the Claim form, but I do not see changes from the screenshot above:

* I do not see airdrop option

* Investment grids look like previous ones to me in this PR
  ![image](https://user-images.githubusercontent.com/70885163/150001668-04ea143d-c1dc-4327-8fcc-1eec0b8c0c9a.png)

It's a different screen Elena. The one we are talking about is the last one, after the approval screen

🤦

@elena-zh
Copy link

The same to me in Win10 +Chrome
image

@elena-zh
Copy link

Hey @biocom , I'm still not 100% sure in this proposal, but maybe we could make this text left-aligned as all the rest elements on the page?
image

@fairlighteth
Copy link
Contributor Author

@elena-zh Yes will address in future PR's.

@elena-zh
Copy link

Thanks! Then, changes under the current PR LGTM!

@elena-zh
Copy link

Just a tiny issue to address in the future PR is to adjust 1st step number to be displayed within the step area in FF:
image

@fairlighteth fairlighteth merged commit d2f8aab into claim-styleImprove-11 Jan 19, 2022
@W3stside
Copy link
Contributor

Agree with comments:

  1. left align text
  2. Can we add padding to the orange highlight text at the top? The steps descriptor

@fairlighteth
Copy link
Contributor Author

@W3stside Yes, planned to address this separately to keep things going.

anxolin added a commit that referenced this pull request Jan 19, 2022
@fairlighteth @anxolin
@alfetopito @lint-action
Improve input field claim (#2186)
2146760 
* Wording change and CSS cleanup.

* Style update + hide approve button for ETH.

* Style updates + organise invest options

* Style updates, input field.

* Style updates, input field.

* Rename max.

* Further investment flow styling.

* Further investment flow styling.

* Further investment flow styling.

* Further investment flow styling.

* Add token symbol images.

* Further styling of investment flow (#2192)

* Further investment flow styling.

* Further investment flow styling.

* Further investment flow styling.

* Further investment flow styling.

* Update src/custom/pages/Claim/ClaimsTable.tsx

Thank you

Co-authored-by: Leandro Boscariol <[email protected]>

* Fix code style issues with Prettier

* Remove unused function.

Co-authored-by: Anxo Rodriguez <[email protected]>
Co-authored-by: Leandro Boscariol <[email protected]>
Co-authored-by: Lint Action <[email protected]>
anxolin pushed a commit to anxolin/cowswap that referenced this pull request Apr 1, 2022
@fairlighteth
Further styling of investment flow (gnosis/cowswap#2192)
52cd449 
* Further investment flow styling.

* Further investment flow styling.

* Further investment flow styling.

* Further investment flow styling.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elena-zh elena-zh elena-zh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fairlighteth @alfetopito @anxolin @elena-zh @W3stside